Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elasticsearch Feed] Authentication Error Bug FIx #27614

Merged

Conversation

samuelFain
Copy link
Contributor

@samuelFain samuelFain commented Jun 21, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-25267

Description

This PR will fix an an issue in Elasticsearch Feed integration where API key based authentication failed due to lack differentiation between authentication methods.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

@samuelFain samuelFain self-assigned this Jun 21, 2023
@samuelFain samuelFain marked this pull request as ready for review June 25, 2023 12:01
Copy link
Contributor

@ShacharKidor ShacharKidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Nice!

Did we test it with both auth methods?
Do we have a valid instance for both methods? if yes - it is worth adding them both to the GSM so the TPB will run on both of them.

@samuelFain
Copy link
Contributor Author

@ShacharKidor, regarding your question - we currently do not have an instance of API key authentication method available for this integration. We only have basic authentication available. The bug fix testing happend through debugging and has also been verified by both the CS and the customer within the ticket.
Also, the relevant UTs has been updated to support the changes.

@ShacharKidor
Copy link
Contributor

@ShacharKidor, regarding your question - we currently do not have an instance of API key authentication method available for this integration. We only have basic authentication available. The bug fix testing happend through debugging and has also been verified by both the CS and the customer within the ticket. Also, the relevant UTs has been updated to support the changes.

@samuelFain - Sounds good.
It is worth opening an issue for the lab to create such an instance for testing.

@samuelFain samuelFain merged commit 22e91a1 into master Jun 26, 2023
@samuelFain samuelFain deleted the bugfix/XSUP-25267/elasticsearch-feed-authentication-error branch June 26, 2023 13:01
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
* Add debug logs

* Add differentiation between authentication methods

* Remove extra debug logs

* Update docker image

* Update release notes

* Add known_words section to .pack-ignore fille

* Update Release Notes

* Update authentication related UTs
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* Add debug logs

* Add differentiation between authentication methods

* Remove extra debug logs

* Update docker image

* Update release notes

* Add known_words section to .pack-ignore fille

* Update Release Notes

* Update authentication related UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants