Traceable AI API Security Platform Integration #27626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added pack documentation
|
|
circle ci validations are failing
|
Hi @mtraceable , |
michal-dagan
requested changes
Jun 26, 2023
There was a problem hiding this comment.
Hi @mtraceable,
Thank you for your contribution!
Good Work!
- please address my comments :)
- please remove these files:
Pipfile
Pipfile.lock
baseintegration-dummy.json
pytest.ini - please revert changes in this file:
devcontainer.json - please change the Author_image.png according to the standard : https://xsoar.pan.dev/docs/packs/packs-format#author_imagepng
- Please use our debugging standards instead of the logging package:
https://xsoar.pan.dev/docs/integrations/code-conventions#logging
https://xsoar.pan.dev/docs/integrations/debugging
https://xsoar.pan.dev/docs/integrations/code-conventions#return_error
https://xsoar.pan.dev/docs/reference/api/common-server-python#return_warning
Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again
michal-dagan
added
the
pending-contributor
michal-dagan
requested changes
Jun 28, 2023
There was a problem hiding this comment.
Hi @mtraceable, looks good
few minor comments:
- Please run
pre-commit -g --unit-test --validate --no-secrets --show-diff-on-failure --verbosecause the pre-commit job failed - Regarding the author image - After I sent you the documentation I saw that the content is not updated, we are now working on updating it in xsoar pan dev, it should be a logo of the contributing company, you can see for example Packs/Binalyze
- Tip: You should use dict.get(key) instead of dict[key]
consider to change in your code accordingly. - Please revert your changes to the devcontainer.json file.
thanks!!
michal-dagan
removed request for
daryakoval,
yucohen,
michalgold,
idovandijk,
GuyAfik,
DeanArbel and
ostolero
demisto-sdk pre-commit -g --unit-test --validate --no-secrets --show-diff-on-failure --verbose /Users/mayuresh/Documents/tmpworkspace/xsoar/content/Packs/Traceable
mtraceable
requested review from
Ni-Knight,
Shellyber and
yaakovpraisler
as code owners
- reverting devcontainer.json
michal-dagan
added
docs-approved
ready-for-instance-test
michal-dagan
approved these changes
Jun 29, 2023
michal-dagan
added a commit
that referenced
this pull request
Jul 6, 2023
* Traceable AI API Security Platform Integration (#27626) * Initial Commit for Traceable Pack * Update .devcontainer.json name * Remove unnecessary fields from the integration. * Some final changes * - Changed support type for Integration - Added pack documentation * Doc Changes * Flake8 changes and formatting changes. * Use mocks for tests. * Changing test data to more dummy like data as circle ci validations are failing * Updating according to validation changes * Changes based on validations * Added Pack README.md contents. * Adding README.md in the proper format * Linter changes * Removing dead code * Added unused code and added tests and other cleanups. * Unused import cleanup * More tests and code restructuring * Including Review comments * Flake8, Lint and Validate corrections. * Review comments * More review changes and added unit tests * Changes based on more review comments. Added more unit tests. * Review comments and recommendations from running: demisto-sdk pre-commit -g --unit-test --validate --no-secrets \ --show-diff-on-failure --verbose * Mypy errors fix * README changes * Corrections from the output of: demisto-sdk pre-commit -g --unit-test --validate --no-secrets --show-diff-on-failure --verbose /Users/mayuresh/Documents/tmpworkspace/xsoar/content/Packs/Traceable * - Changing the author image - reverting devcontainer.json --------- Co-authored-by: mtraceable <mtraceable@users.noreply.github.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> * updated test_module --------- Co-authored-by: Mayuresh Kshirsagar <101903400+mtraceable@users.noreply.github.com> Co-authored-by: mtraceable <mtraceable@users.noreply.github.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> Co-authored-by: michal-dagan <mdagan@paloaltonetworks.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* Traceable AI API Security Platform Integration (demisto#27626) * Initial Commit for Traceable Pack * Update .devcontainer.json name * Remove unnecessary fields from the integration. * Some final changes * - Changed support type for Integration - Added pack documentation * Doc Changes * Flake8 changes and formatting changes. * Use mocks for tests. * Changing test data to more dummy like data as circle ci validations are failing * Updating according to validation changes * Changes based on validations * Added Pack README.md contents. * Adding README.md in the proper format * Linter changes * Removing dead code * Added unused code and added tests and other cleanups. * Unused import cleanup * More tests and code restructuring * Including Review comments * Flake8, Lint and Validate corrections. * Review comments * More review changes and added unit tests * Changes based on more review comments. Added more unit tests. * Review comments and recommendations from running: demisto-sdk pre-commit -g --unit-test --validate --no-secrets \ --show-diff-on-failure --verbose * Mypy errors fix * README changes * Corrections from the output of: demisto-sdk pre-commit -g --unit-test --validate --no-secrets --show-diff-on-failure --verbose /Users/mayuresh/Documents/tmpworkspace/xsoar/content/Packs/Traceable * - Changing the author image - reverting devcontainer.json --------- Co-authored-by: mtraceable <mtraceable@users.noreply.github.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> * updated test_module --------- Co-authored-by: Mayuresh Kshirsagar <101903400+mtraceable@users.noreply.github.com> Co-authored-by: mtraceable <mtraceable@users.noreply.github.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> Co-authored-by: michal-dagan <mdagan@paloaltonetworks.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* Traceable AI API Security Platform Integration (demisto#27626) * Initial Commit for Traceable Pack * Update .devcontainer.json name * Remove unnecessary fields from the integration. * Some final changes * - Changed support type for Integration - Added pack documentation * Doc Changes * Flake8 changes and formatting changes. * Use mocks for tests. * Changing test data to more dummy like data as circle ci validations are failing * Updating according to validation changes * Changes based on validations * Added Pack README.md contents. * Adding README.md in the proper format * Linter changes * Removing dead code * Added unused code and added tests and other cleanups. * Unused import cleanup * More tests and code restructuring * Including Review comments * Flake8, Lint and Validate corrections. * Review comments * More review changes and added unit tests * Changes based on more review comments. Added more unit tests. * Review comments and recommendations from running: demisto-sdk pre-commit -g --unit-test --validate --no-secrets \ --show-diff-on-failure --verbose * Mypy errors fix * README changes * Corrections from the output of: demisto-sdk pre-commit -g --unit-test --validate --no-secrets --show-diff-on-failure --verbose /Users/mayuresh/Documents/tmpworkspace/xsoar/content/Packs/Traceable * - Changing the author image - reverting devcontainer.json --------- Co-authored-by: mtraceable <mtraceable@users.noreply.github.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> * updated test_module --------- Co-authored-by: Mayuresh Kshirsagar <101903400+mtraceable@users.noreply.github.com> Co-authored-by: mtraceable <mtraceable@users.noreply.github.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> Co-authored-by: michal-dagan <mdagan@paloaltonetworks.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* Traceable AI API Security Platform Integration (demisto#27626) * Initial Commit for Traceable Pack * Update .devcontainer.json name * Remove unnecessary fields from the integration. * Some final changes * - Changed support type for Integration - Added pack documentation * Doc Changes * Flake8 changes and formatting changes. * Use mocks for tests. * Changing test data to more dummy like data as circle ci validations are failing * Updating according to validation changes * Changes based on validations * Added Pack README.md contents. * Adding README.md in the proper format * Linter changes * Removing dead code * Added unused code and added tests and other cleanups. * Unused import cleanup * More tests and code restructuring * Including Review comments * Flake8, Lint and Validate corrections. * Review comments * More review changes and added unit tests * Changes based on more review comments. Added more unit tests. * Review comments and recommendations from running: demisto-sdk pre-commit -g --unit-test --validate --no-secrets \ --show-diff-on-failure --verbose * Mypy errors fix * README changes * Corrections from the output of: demisto-sdk pre-commit -g --unit-test --validate --no-secrets --show-diff-on-failure --verbose /Users/mayuresh/Documents/tmpworkspace/xsoar/content/Packs/Traceable * - Changing the author image - reverting devcontainer.json --------- Co-authored-by: mtraceable <mtraceable@users.noreply.github.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> * updated test_module --------- Co-authored-by: Mayuresh Kshirsagar <101903400+mtraceable@users.noreply.github.com> Co-authored-by: mtraceable <mtraceable@users.noreply.github.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> Co-authored-by: michal-dagan <mdagan@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have