Crowdstrike OpenAPI: Fixed the the cs-download-sensor-installer-by-id command #27655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mand was not returned the file.
yuvalbenshalom
requested changes
Jun 22, 2023
| file_name = response.headers.get('Content-Disposition').split('attachment; filename=')[1] | ||
| except Exception as err: | ||
| demisto.debug(f'Failed extracting filename from response headers - [{str(err)}]') | ||
| file_name = 'cs_installer.exe' |
There was a problem hiding this comment.
are you sure we so not get the installer name in the response? I think the installer can be also for Linux or Mac, so it may not be just for windows, so it is possible it will not be an .exe file.
|
|
||
| #### Integrations | ||
| ##### CrowdStrike OpenAPI (Beta) | ||
| - Fixed an issue where the ***cs-download-sensor-installer-by-id*** command was not download the file. |
There was a problem hiding this comment.
Suggested change
| - Fixed an issue where the ***cs-download-sensor-installer-by-id*** command was not download the file. | |
| - Fixed an issue where the ***cs-download-sensor-installer-by-id*** command failed. |
yuvalbenshalom
approved these changes
Jun 25, 2023
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
… command (#27655) * Fixed an issue where the ***cs-download-sensor-installer-by-id*** command was not returned the file. * update dockerimage * changed the file name to be generic
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
… command (demisto#27655) * Fixed an issue where the ***cs-download-sensor-installer-by-id*** command was not returned the file. * update dockerimage * changed the file name to be generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mand was not returned the file.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have