fix a bug in Cortex XDR - XQL Query Engine - replace 'tenant_ids' with 'tenent_id' #27661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RosenbergYehuda
changed the title
ShacharKidor
requested changes
Jun 22, 2023
|
|
||
| ##### Cortex XDR - XQL Query Engine | ||
|
|
||
| - Fixed an issue when using the 'tenant_id' argument in the ***xdr-xql-generic-query*** command. |
There was a problem hiding this comment.
Suggested change
| - Fixed an issue when using the 'tenant_id' argument in the ***xdr-xql-generic-query*** command. | |
| - Fixed an issue in the ***xdr-xql-generic-query*** command where the *tenant_id* argument wasn't used. |
| @@ -351,7 +351,7 @@ def start_xql_query(client: Client, args: Dict[str, Any]) -> str: | |||
| time_frame = args.get('time_frame') | |||
| if time_frame: | |||
| data['request_data']['timeframe'] = convert_timeframe_string_to_json(time_frame) | |||
| tenant_ids = argToList(args.get('tenant_ids')) | |||
| tenant_ids = argToList(args.get('tenant_id') or args.get('tenant_ids')) | |||
There was a problem hiding this comment.
Let's a comment saying that tenant_ids is used for maintaining BC.
ShacharKidor
approved these changes
Jun 22, 2023
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
…h 'tenent_id' (#27661) * fix and test * docker * RN * CR
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
…h 'tenent_id' (demisto#27661) * fix and test * docker * RN * CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-25528
Description
The bug was that the arg name is 'tenant_id', but the code was 'args.get('tenant_ids')'
in order to fix that without BC in case someone is using it with the wrong arg name , we added support for both.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have