Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added notes to ms teams readme #27690

Merged
merged 15 commits into from
Jun 26, 2023
Merged

added notes to ms teams readme #27690

merged 15 commits into from
Jun 26, 2023

Conversation

merit-maita
Copy link
Contributor

@merit-maita merit-maita commented Jun 25, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Added notes to readme of microsoft teams for XSOAR 8.
  • Removed the deprecated method of app studio to configure the bot.

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShirleyDenkberg Please take a look and work with @merit-maita on this.

@ShirleyDenkberg
Copy link
Contributor

@DeanArbel @thefrieddan1 @anara123 Doc review completed.

merit-maita and others added 11 commits June 25, 2023 23:13
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@merit-maita merit-maita requested a review from DeanArbel June 26, 2023 05:31
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@merit-maita merit-maita merged commit b335807 into master Jun 26, 2023
@merit-maita merit-maita deleted the update_content_docs branch June 26, 2023 06:58
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
* added notes to ms teams readme

* fixed notes

* updated readme

* removed the app studio method

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* removed the app studio method

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* added notes to ms teams readme

* fixed notes

* updated readme

* removed the app studio method

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/MicrosoftTeams/Integrations/MicrosoftTeams/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* removed the app studio method

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants