Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google align credentials stores - part 25 #27699

Merged
merged 2 commits into from
Jun 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Packs/GoogleCloudCompute/.pack-ignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ ignore=RM104
[file:playbook-IP_Whitelist_-_GCP_Firewall.yml]
ignore=PB114,PB115

[file:GoogleCloudCompute.yml]
ignore=IN145

[file:GoogleCloudCompute_image.png]
ignore=IM111

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
""" GLOBALS/PARAMS """

# Params for assembling object of the Service Account Credentials File Contents
SERVICE_ACCOUNT_FILE = demisto.params().get('service')
SERVICE_ACCOUNT_FILE = demisto.params().get('credentials_service_account_json',
{}).get('password') or demisto.params().get('service')
SERVICE_ACT_PROJECT_ID = None

# Params for constructing googleapiclient service object
Expand Down Expand Up @@ -4516,6 +4517,8 @@ def add_networks_tag(args: Dict[str, Any]) -> CommandResults:


def main():
if not SERVICE_ACCOUNT_FILE:
raise DemistoException('Service Account Private Key file contents must be provided.')
try:
build_and_authenticate(GSERVICE)
command = demisto.command()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,14 @@ commonfields:
configuration:
- display: Service Account Private Key file contents (JSON)
name: service
required: true
required: false
type: 4
hidden: true
- displaypassword: Service Account Private Key file contents (JSON)
name: credentials_service_account_json
required: false
hiddenusername: true
type: 9
- display: Use system proxy settings
name: proxy
required: false
Expand Down Expand Up @@ -8412,7 +8418,7 @@ script:
- contextPath: GoogleCloudCompute.Instances.kind
description: '] Type of the resource. Always compute#instance for instances.'
type: string
dockerimage: demisto/googleapi-python3:1.0.0.50652
dockerimage: demisto/googleapi-python3:1.0.0.64077
runonce: false
script: ''
subtype: python3
Expand Down
6 changes: 6 additions & 0 deletions Packs/GoogleCloudCompute/ReleaseNotes/1_1_3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Google Cloud Compute
- Added the *Service Account Private Key file contents* integration parameters to support credentials fetching object.
- Updated the Docker image to: *demisto/googleapi-python3:1.0.0.64077*.
2 changes: 1 addition & 1 deletion Packs/GoogleCloudCompute/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Google Cloud Compute",
"description": "Google Compute Engine delivers virtual machines running in Google's innovative data centers and worldwide fiber network. Compute Engine's tooling and workflow support enable scaling from single instances to global, load-balanced cloud computing.",
"support": "xsoar",
"currentVersion": "1.1.2",
"currentVersion": "1.1.3",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
3 changes: 0 additions & 3 deletions Packs/GoogleCloudStorage/.pack-ignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,5 @@ ignore=auto-test
[file:playbook-GCS_Object_Policy_(ACL)_Test.yml]
ignore=auto-test

[file:GoogleCloudStorage.yml]
ignore=IN145

[file:GoogleCloudStorage_image.png]
ignore=IM111
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,9 @@ def main():
args = demisto.args()
command = demisto.command()

service_account = params.get('service_account_json', '')
service_account = params.get('credentials_service_account_json', {}).get('password') or params.get('service_account_json', '')
if not service_account:
raise DemistoException('Service Account Private Key file contents must be provided.')
default_bucket = params.get('default_bucket')
insecure = params.get('insecure', False)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,14 @@ commonfields:
configuration:
- display: Service Account Private Key file contents (JSON)
name: service_account_json
required: true
required: false
type: 4
hidden: true
- displaypassword: Service Account Private Key file contents (JSON)
name: credentials_service_account_json
required: false
hiddenusername: true
type: 9
- display: Default Bucket
name: default_bucket
required: false
Expand Down Expand Up @@ -508,7 +514,7 @@ script:
description: Removes an entity from an object's Access Control List.
execution: false
name: gcs-delete-bucket-object-policy
dockerimage: demisto/google-cloud-storage:1.0.0.42893
dockerimage: demisto/google-cloud-storage:1.0.0.63865
isfetch: false
longRunning: false
longRunningPort: false
Expand Down
6 changes: 6 additions & 0 deletions Packs/GoogleCloudStorage/ReleaseNotes/1_0_10.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Google Cloud Storage
- Added the *Service Account Private Key file contents* integration parameters to support credentials fetching object.
- Updated the Docker image to: *demisto/google-cloud-storage:1.0.0.63865*.
2 changes: 1 addition & 1 deletion Packs/GoogleCloudStorage/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Google Cloud Storage",
"description": "Google Cloud Storage is a RESTful online file storage web service for storing and accessing data on Google Cloud Platform infrastructure.",
"support": "xsoar",
"currentVersion": "1.0.9",
"currentVersion": "1.0.10",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down