Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials stores - part 32 #27756

Merged
merged 15 commits into from
Jun 29, 2023
Merged

Conversation

maimorag
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Relates: link to the issue

Description

Change the type of credentials, from type 4 to type 9.

Minimum version of Cortex XSOAR

  • 6.5.0

Does it break backward compatibility?

  • No

@maimorag
Copy link
Contributor Author

build fails since ProtectWise doesn't have unit tests and the playbook is currently in skipped

@maimorag maimorag requested a review from Shellyber June 28, 2023 10:41
@maimorag maimorag requested a review from ostolero as a code owner June 28, 2023 10:54
@Shellyber
Copy link
Contributor

Please check ProtectWise test playbook, and remove it from skip. We have creds

@Shellyber Shellyber removed the request for review from ostolero June 28, 2023 11:23
Shellyber
Shellyber previously approved these changes Jun 28, 2023
@maimorag
Copy link
Contributor Author

(CJ105) ProtectWise build fail since the playbook is skipped (Issue )

@maimorag maimorag added the ForceMerge Forcing the merge of the PR despite the build status label Jun 29, 2023
@Shellyber
Copy link
Contributor

@maimorag Why ProtectWise is skipped again? didn't you update the creds?

@Shellyber Shellyber self-requested a review June 29, 2023 12:06
@Shellyber Shellyber dismissed their stale review June 29, 2023 12:07

Check regarding tpb

@dantavori dantavori merged commit 25bf006 into master Jun 29, 2023
@dantavori dantavori deleted the align_credentials_stores_part_32 branch June 29, 2023 13:29
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* Align credentials stores - part 32

* adding Recorded Future Feed

* fix test

* Bump pack from version FeedCrowdstrikeFalconIntel to 2.1.9.

* revert change

* adding ignore

* removing from conf.json

* fix

* fix test

* cred invalid

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants