[Microsoft Teams] Fix URL RegEx #27846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelYochpaz
force-pushed
the
fix-ms-teams-links
branch
from
36d7c59
to
08bed8c
Compare
|
@bziser Many of the changes are due to ruff autofixes. You can see a diff without them (only with fix-related changes) here: |
bziser
reviewed
Jul 2, 2023
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
bziser
previously approved these changes
Jul 2, 2023
MichaelYochpaz
force-pushed
the
fix-ms-teams-links
branch
from
c723b0e
to
68bee93
Compare
MichaelYochpaz
force-pushed
the
fix-ms-teams-links
branch
from
68bee93
to
a4b6b99
Compare
MichaelYochpaz
force-pushed
the
fix-ms-teams-links
branch
from
ec207f6
to
38ce8ad
Compare
bziser
reviewed
Jul 2, 2023
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
MichaelYochpaz
force-pushed
the
fix-ms-teams-links
branch
from
38ce8ad
to
24b476f
Compare
MichaelYochpaz
force-pushed
the
fix-ms-teams-links
branch
from
4b40341
to
700c9e9
Compare
Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
bziser
reviewed
Jul 3, 2023
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
bziser
approved these changes
Jul 3, 2023
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* Update unit-test * Bump version * Ruff auto-fixes * Fix invalid URLs failing unit-tests * Fix token being fetched, making tests fail when running locally * Fix test URLs to valid URLs * Update RegEx * Apply suggestions from code review Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com> --------- Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Fix URL RegEx which previously didn't capture URL parameters (ex:
?param=1) to capture any string that starts with http/https.Screenshots
Before and after:
