Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowdstrike falcon run command timeout #27858

Merged
merged 13 commits into from
Jul 6, 2023

Conversation

gal-forer
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/XSUP-25785

Description

Added the timeout param as requested.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@gal-forer gal-forer requested a review from DeanArbel July 2, 2023 18:44
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Please make sure the code's default value matches the yml default value

@gal-forer gal-forer merged commit 97b5c0b into master Jul 6, 2023
@gal-forer gal-forer deleted the crowdstrike-falcon-run-command-timeout branch July 6, 2023 07:34
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* Added the timeout param

* Added the timeout param

* Added the timeout param

* Release notes

* Release notes

* Fix conflicts

* Fix conflicts

* Fix conflicts

* Fix conflicts

* Fix conflicts

* Fix conflicts
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Added the timeout param

* Added the timeout param

* Added the timeout param

* Release notes

* Release notes

* Fix conflicts

* Fix conflicts

* Fix conflicts

* Fix conflicts

* Fix conflicts

* Fix conflicts
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Added the timeout param

* Added the timeout param

* Added the timeout param

* Release notes

* Release notes

* Fix conflicts

* Fix conflicts

* Fix conflicts

* Fix conflicts

* Fix conflicts

* Fix conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants