Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cveReputationV2 to handle None value #27938

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

Ni-Knight
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Fixes an issue where the script failed when cvss was None

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@Ni-Knight Ni-Knight merged commit 03b5b0f into master Jul 6, 2023
@Ni-Knight Ni-Knight deleted the dra-cvereputation-none-fix branch July 6, 2023 13:16
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* Added cases for None and a cvss.Score

* RN

* Update Packs/CommonScripts/Scripts/CveReputationV2/CveReputationV2.py

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* Fixed None cass in "Score" and tests

* lowercase

---------

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Added cases for None and a cvss.Score

* RN

* Update Packs/CommonScripts/Scripts/CveReputationV2/CveReputationV2.py

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* Fixed None cass in "Score" and tests

* lowercase

---------

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Added cases for None and a cvss.Score

* RN

* Update Packs/CommonScripts/Scripts/CveReputationV2/CveReputationV2.py

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* Fixed None cass in "Score" and tests

* lowercase

---------

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants