[Feedly] Initial Integration #29822

Mathieu4141 · 2023-09-21T14:46:22Z

Contributing to Cortex XSOAR Content

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

N/A

Description

Adding an integration with Feedly. The integration will pull articles with entities, IoCs and their relationships, and create the corresponding indicators in XSOAR.

Must have

Tests
Documentation

CLAassistant · 2023-09-21T14:46:28Z

All committers have signed the CLA.

MichaelYochpaz · 2023-09-21T17:07:01Z

Hi @Mathieu4141, thank you for your contribution.
Your PR review will be slightly delayed since it is the holiday season in Israel, and we have a holiday this weekend (21th-25th of September), I apologize in advance.

MichaelYochpaz · 2023-09-26T07:29:31Z

Hey @Mathieu4141, thank you for the contribution.
Please fill the contribution form. Without it, we cannot start the contribution process.

Mathieu4141 · 2023-09-26T10:05:36Z

Hey @Mathieu4141, thank you for the contribution. Please fill the contribution form. Without it, we cannot start the contribution process.

Done! Sorry I was missing some details to fill it before
Let me know if you need anything more before reviewing

MichaelYochpaz · 2023-09-27T11:58:00Z

@Mathieu4141 Hey, looks like it's good to go for a review now, and you've completed all the required tasks :)
Please note that there might be a few days delay in the review process since the contribution PRs queue is a bit overloaded.
I apologize in advance

MichaelYochpaz

Hey, I'm still reviewing the code, but there are a few notes I made that can be addressed in the meantime.

Please also pull and merge from master to your branch, and fix the errors here:
https://github.com/demisto/content/actions/runs/6263315560/job/17011882198?pr=29822

Feel free to reach out to me here or on the DFIR Slack if you need any help.

Packs/Feedly/Integrations/Feedly/Feedly.py

Packs/Feedly/Integrations/Feedly/README.md

MichaelYochpaz · 2023-10-01T11:18:08Z

Packs/Feedly/.secrets-ignore

@@ -0,0 +1,3 @@
+https://api.feedly.com
+https://feedly.com
+base_url=FEEDLY_BASE_URL,


Why is that added here? Is this line detected as a secret?

yes it was detected as a secret

Packs/Feedly/Integrations/Feedly/Feedly.py

Packs/Feedly/Integrations/Feedly/Feedly_test.py

Packs/Feedly/Integrations/Feedly/test_data/FeedHelloWorld_mock.txt

MichaelYochpaz

Some additional notes

Packs/Feedly/Integrations/Feedly/Feedly.yml

Packs/Feedly/Integrations/Feedly/Feedly.py

Packs/Feedly/Integrations/Feedly/Feedly.yml

Packs/Feedly/Integrations/Feedly/Feedly.py

MichaelYochpaz

Some additional notes following the last changes. (seems like you've replaced the name of the files using the IDE, and it changed them in some unwanted places?)

Please also note the failing validations and linting error.

Packs/FeedFeedly/pack_metadata.json

Packs/FeedFeedly/README.md

Packs/FeedFeedly/Integrations/FeedFeedly/README.md

Packs/FeedFeedly/Integrations/FeedFeedly/FeedFeedly.py

MichaelYochpaz · 2023-10-08T06:34:01Z

@Mathieu4141 Hey, you have 2 failing linting / unit-test validations:

A mypy error:

/home/circleci/project/Packs/FeedFeedly/Integrations/FeedFeedly/FeedFeedly.py:691:72: error:
Argument 1 to "is_valid_type" of "RelationshipsTypes" has incompatible type
"Optional[Any]"; expected "str"  [arg-type]
    ...ntityRelationship.RelationshipsTypes.is_valid_type(relationship_type):
                                                          ^~~~~~~~~~~~~~~~~
Found 1 error in 1 file (checked 1 source file)

Your unit-test coverage is too low. We require a minimum of 70% coverage (currently at 59.8%).

Please fix :)

Ni-Knight · 2023-10-12T13:04:00Z

Hi @Mathieu4141 I would put it a bit different

Main on the left is a single field section, only Description MD, all the rest on the left in that order. That is also XSOAR best practice.

JSON:
layoutscontainer-Feedly_Report.json

And maybe an image of Unit42 report next time and not Sentinel One ;)

MichaelYochpaz · 2023-10-12T13:19:59Z

@Mathieu4141 Also note that I don't see you've addressed the previously mentioned limit parameter issue in your recent changes, so I'm assuming it is still unfixed?

Adding @melamedbn to the review since files that are reviewed by our security team (custom layout and indicator type) were added.

Packs/FeedFeedly/Integrations/FeedFeedly/FeedFeedly.py

…egration

MichaelYochpaz · 2023-10-15T14:59:19Z

@Mathieu4141 Please fix the following failing validations.
All should be easily fixed by running:

demisto-sdk format -i "Packs/FeedFeedly/Layouts/layoutscontainer-FeedlyReport.json"

Other than that, it looks good to me and ready for a merge (assuming the others don't have any additional notes).
Good job :)

MichaelYochpaz

Looks good to me, good job :)
Please make sure to re-test the layout & reports and that they work properly following your last changes.

Waiting for @melamedbn's and @Ni-Knight's approvals for a merge.

Mathieu4141 · 2023-10-16T09:52:54Z

Looks good to me, good job :) Please make sure to re-test the layout & reports and that they work properly following your last changes.

Yes everything works correctly!

Thanks for all your reviews!

Ni-Knight

Only one comment about tags.

Packs/FeedFeedly/pack_metadata.json

Ni-Knight

Well done.

melamedbn · 2023-10-18T12:53:41Z

Hi @Mathieu4141,

We'll be ready if you can fix the panels' positioning in the layout grid, so we won't have blank spaces and add a layout description.
Take the following screenshot as an optional example:

Adjusted

Best regards,
Ben

…dly/create-integration

* [Feedly] Initial Integration (#29822) * [feedly] initial integration * [feedly] pr.review * [feedly] address pre commit checks * [feedly] fix image sizes * [feedly] pr.review * [feedly] pr.review * [feedly] pr.review * [feedly] update image * [feedly] increase coverage and fix typing * [feedly] fix relationships and test it * [feedly] fix indicators imit * [feedly] add TTP and threat tags * [feedly] order of params * [feedly] Add custom FeedlyReport for better visualization * [feedly] fixes * [feedly] fix feedyl report layout * [feedly] add to free feeds * [feedly] (layout) pr.review * [feedly] format layout file * [feedly] update image --------- Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Bump Docker image --------- Co-authored-by: Mathieu Béligon <beligonmathieu@gmail.com> Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

[feedly] initial integration

a99900e

content-bot assigned MichaelYochpaz Sep 21, 2023

MichaelYochpaz added the pending-contributor The PR is pending the response of its creator label Sep 26, 2023

content-bot assigned edik24 Sep 26, 2023

MichaelYochpaz removed the pending-contributor The PR is pending the response of its creator label Sep 26, 2023

MichaelYochpaz reviewed Oct 1, 2023

View reviewed changes

MichaelYochpaz added the pending-contributor The PR is pending the response of its creator label Oct 2, 2023

Mathieu4141 added 4 commits October 2, 2023 19:41

[feedly] pr.review

bfc4b72

Merge branch 'master' into feedly/create-integration

5c07fa5

[feedly] address pre commit checks

e25e218

[feedly] fix image sizes

9de18a9

MichaelYochpaz reviewed Oct 3, 2023

View reviewed changes

[feedly] pr.review

190d09d

MichaelYochpaz reviewed Oct 3, 2023

View reviewed changes

[feedly] pr.review

ae9df16

MichaelYochpaz removed the pending-contributor The PR is pending the response of its creator label Oct 3, 2023

MichaelYochpaz requested a review from MLainer1 October 4, 2023 08:17

MichaelYochpaz changed the title ~~[feedly] initial integration~~ [Feedly] Initial Integration Oct 4, 2023

MichaelYochpaz added the pending-contributor The PR is pending the response of its creator label Oct 5, 2023

Mathieu4141 added 2 commits October 5, 2023 10:36

[feedly] pr.review

b5688f9

[feedly] update image

51f61e3

[feedly] increase coverage and fix typing

dc5873d

MichaelYochpaz added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed pending-contributor The PR is pending the response of its creator labels Oct 9, 2023

MichaelYochpaz added the Security Review label Oct 12, 2023

MichaelYochpaz requested a review from melamedbn October 12, 2023 13:21

Mathieu4141 commented Oct 12, 2023

View reviewed changes

Packs/FeedFeedly/Integrations/FeedFeedly/FeedFeedly.py Show resolved Hide resolved

Mathieu4141 added 2 commits October 12, 2023 15:46

[feedly] fixes

b47f99f

Merge remote-tracking branch 'upstream/master' into feedly/create-int…

a170705

…egration

melamedbn self-assigned this Oct 15, 2023

MichaelYochpaz added the pending-contributor The PR is pending the response of its creator label Oct 16, 2023

[feedly] fix feedyl report layout

cdfa81a

MichaelYochpaz approved these changes Oct 16, 2023

View reviewed changes

MichaelYochpaz removed the pending-contributor The PR is pending the response of its creator label Oct 16, 2023

Ni-Knight reviewed Oct 16, 2023

View reviewed changes

Packs/FeedFeedly/pack_metadata.json Outdated Show resolved Hide resolved

[feedly] add to free feeds

9a46b7c

Ni-Knight approved these changes Oct 17, 2023

View reviewed changes

MichaelYochpaz added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Oct 17, 2023

Mathieu4141 added 3 commits October 18, 2023 16:18

[feedly] (layout) pr.review

759e49b

[feedly] format layout file

a95b780

[feedly] update image

16cc419

melamedbn approved these changes Oct 22, 2023

View reviewed changes

Merge branch 'contrib/Mathieu4141_feedly/create-integration' into fee…

025b445

…dly/create-integration

MichaelYochpaz added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Oct 22, 2023

MichaelYochpaz merged commit befe3f8 into demisto:contrib/Mathieu4141_feedly/create-integration Oct 22, 2023
22 of 24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feedly] Initial Integration #29822

[Feedly] Initial Integration #29822

Mathieu4141 commented Sep 21, 2023 •

edited

Loading

CLAassistant commented Sep 21, 2023 •

edited

Loading

MichaelYochpaz commented Sep 21, 2023

MichaelYochpaz commented Sep 26, 2023

Mathieu4141 commented Sep 26, 2023

MichaelYochpaz commented Sep 27, 2023

MichaelYochpaz left a comment

MichaelYochpaz Oct 1, 2023

Mathieu4141 Oct 2, 2023

MichaelYochpaz left a comment

MichaelYochpaz left a comment

MichaelYochpaz commented Oct 8, 2023 •

edited

Loading

Ni-Knight commented Oct 12, 2023 •

edited

Loading

MichaelYochpaz commented Oct 12, 2023

MichaelYochpaz commented Oct 15, 2023

MichaelYochpaz left a comment

Mathieu4141 commented Oct 16, 2023

Ni-Knight left a comment

Ni-Knight left a comment

melamedbn commented Oct 18, 2023

[Feedly] Initial Integration #29822

[Feedly] Initial Integration #29822

Conversation

Mathieu4141 commented Sep 21, 2023 • edited Loading

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Must have

CLAassistant commented Sep 21, 2023 • edited Loading

MichaelYochpaz commented Sep 21, 2023

MichaelYochpaz commented Sep 26, 2023

Mathieu4141 commented Sep 26, 2023

MichaelYochpaz commented Sep 27, 2023

MichaelYochpaz left a comment

Choose a reason for hiding this comment

MichaelYochpaz Oct 1, 2023

Choose a reason for hiding this comment

Mathieu4141 Oct 2, 2023

Choose a reason for hiding this comment

MichaelYochpaz left a comment

Choose a reason for hiding this comment

MichaelYochpaz left a comment

Choose a reason for hiding this comment

MichaelYochpaz commented Oct 8, 2023 • edited Loading

Ni-Knight commented Oct 12, 2023 • edited Loading

MichaelYochpaz commented Oct 12, 2023

MichaelYochpaz commented Oct 15, 2023

MichaelYochpaz left a comment

Choose a reason for hiding this comment

Mathieu4141 commented Oct 16, 2023

Ni-Knight left a comment

Choose a reason for hiding this comment

Ni-Knight left a comment

Choose a reason for hiding this comment

melamedbn commented Oct 18, 2023

Mathieu4141 commented Sep 21, 2023 •

edited

Loading

CLAassistant commented Sep 21, 2023 •

edited

Loading

MichaelYochpaz commented Oct 8, 2023 •

edited

Loading

Ni-Knight commented Oct 12, 2023 •

edited

Loading