Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevSecOps] MinIO Bug fix and add new commands #30132

Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

This PR adds 3 commands to the integration MinIO:

  • minio-copy-object: Create an object by server-side copying data from another object.
  • minio-set-tag: Set tags configuration to an object.
  • minio-get-tags: Get tags configuration of an object.

It also fix an issue where the parameter bucket_name had an predefined value to empty string which show a dropdown menu for the minio-put-object and minio-fput-object commands. It fix the same issue on the parameter length for the minio-get-object command.

Here is the visual picture:
image
Here is the code:
image

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Community Support Level Indicates that the contribution is for Community supported pack labels Oct 12, 2023
@content-bot content-bot changed the base branch from master to contrib/pl-brault_plb-minio_bug October 12, 2023 12:07
@content-bot content-bot requested a review from ilappe October 12, 2023 12:08
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@ghost ghost force-pushed the plb-minio_bug branch 2 times, most recently from da65a14 to 77d1901 Compare October 12, 2023 14:03
Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pl-brault for your contribution!
great job!
please see my review comment
in addition - please see the build errors

if you need any help, i'm here..

Packs/DevSecOps/Integrations/MinIO/MinIO.yml Show resolved Hide resolved
Packs/DevSecOps/Integrations/MinIO/MinIO.py Outdated Show resolved Hide resolved
Packs/DevSecOps/Integrations/MinIO/MinIO.py Outdated Show resolved Hide resolved
Packs/DevSecOps/Integrations/MinIO/MinIO.py Outdated Show resolved Hide resolved
Packs/DevSecOps/Integrations/MinIO/MinIO.py Outdated Show resolved Hide resolved
Packs/DevSecOps/Integrations/MinIO/MinIO.py Show resolved Hide resolved
Packs/DevSecOps/Integrations/MinIO/MinIO.py Show resolved Hide resolved
Packs/DevSecOps/Integrations/MinIO/MinIO.py Show resolved Hide resolved
Packs/DevSecOps/Integrations/MinIO/MinIO.yml Outdated Show resolved Hide resolved
Packs/DevSecOps/Integrations/MinIO/MinIO.py Outdated Show resolved Hide resolved
@ilappe ilappe added the pending-contributor The PR is pending the response of its creator label Oct 16, 2023
@ghost ghost force-pushed the plb-minio_bug branch 6 times, most recently from f9ef050 to 99050c5 Compare October 16, 2023 11:44
@ghost
Copy link
Author

ghost commented Oct 16, 2023

Hi @ilappe
I've fix all your review comments and there no more build errors

@ilappe ilappe added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. pending-demo Demo pending and removed pending-contributor The PR is pending the response of its creator labels Oct 18, 2023
@content-bot
Copy link
Collaborator

content-bot commented Oct 18, 2023

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6638084

@ilappe ilappe added post-demo and removed pending-demo Demo pending labels Oct 18, 2023
Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@ilappe ilappe merged commit 34b8e39 into demisto:contrib/pl-brault_plb-minio_bug Oct 18, 2023
ilappe pushed a commit that referenced this pull request Oct 19, 2023
Co-authored-by: pl-brault <143391737+pl-brault@users.noreply.github.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
Co-authored-by: pl-brault <143391737+pl-brault@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants