-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevSecOps] MinIO Bug fix and add new commands #30132
[DevSecOps] MinIO Bug fix and add new commands #30132
Conversation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed. |
da65a14
to
77d1901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pl-brault for your contribution!
great job!
please see my review comment
in addition - please see the build errors
- validation some small issue about the docker image and
.
missed - Lint issue
if you need any help, i'm here..
f9ef050
to
99050c5
Compare
Hi @ilappe |
6c1a4e4
to
4d64b71
Compare
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6638084 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
This PR adds 3 commands to the integration
MinIO
:It also fix an issue where the parameter
bucket_name
had an predefined value to empty string which show a dropdown menu for theminio-put-object
andminio-fput-object
commands. It fix the same issue on the parameterlength
for theminio-get-object
command.Here is the visual picture:
![image](https://private-user-images.githubusercontent.com/143391737/274589732-d792fbfd-1170-45b1-85a2-31500138ffd4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk4MzU3NjMsIm5iZiI6MTczOTgzNTQ2MywicGF0aCI6Ii8xNDMzOTE3MzcvMjc0NTg5NzMyLWQ3OTJmYmZkLTExNzAtNDViMS04NWEyLTMxNTAwMTM4ZmZkNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxN1QyMzM3NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kNzdiNDIxMDdiOTVjMDEzYzA4YzRkZDdhZGRhNmM1MjQ2YmM3NzgxNGI4MWJlMmE1NjMyNDc4NzVjODViMmU3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.do5svLh4r9Bc5RlkhIUtxG2ZMcecvQsiG3z9MiQ2aK0)
![image](https://private-user-images.githubusercontent.com/143391737/274590155-887ebc57-e451-47ab-922e-4aae4c3ce499.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk4MzU3NjMsIm5iZiI6MTczOTgzNTQ2MywicGF0aCI6Ii8xNDMzOTE3MzcvMjc0NTkwMTU1LTg4N2ViYzU3LWU0NTEtNDdhYi05MjJlLTRhYWU0YzNjZTQ5OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxN1QyMzM3NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kYTJkNjgyNmQ3NmZkMDJiZjU1ZDZmMzdmNWNlYmZhM2EwMTk3NmYxZTA2ZjVlMzYwMmY3ZjRlN2VjNDAwNzAwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.oCGxTT8HjNaL4R5W6wjXEvsgFGtG3zjXqOaduBmDj_w)
Here is the code:
Must have