Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PANOS-EXPANDR-5997 #30156

Merged
merged 9 commits into from
Oct 17, 2023
Merged

PANOS-EXPANDR-5997 #30156

merged 9 commits into from
Oct 17, 2023

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/EXPANDR-5997

Description

Added the SecondaryDeviceGroup input in the case that we want to add the block rule to the "Shared" location put still push to applicable device-groups.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Oct 12, 2023
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Oct 12, 2023
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_PANOS-PB-EXPANDR-5997 October 12, 2023 20:15
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @sapirshuker will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @johnnywilkes, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , can you please review?

@ShirleyDenkberg ShirleyDenkberg self-assigned this Oct 13, 2023
@ShirleyDenkberg
Copy link
Contributor

@melamedbn @sapirshuker Doc review completed.

@johnnywilkes @ShirleyDenkberg
Apply suggestions from code review
27dd674 
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@johnnywilkes
Copy link
Contributor Author

@melamedbn / @sapirshuker , i shared a demo via Google Drive. Please let me know if I should share with anyone else

melamedbn
melamedbn reviewed Oct 15, 2023
View reviewed changes
Packs/PAN-OS/ReleaseNotes/2_1_10.md Outdated

##### PAN-OS - Block Destination Service

Added the `SecondaryDeviceGroup` input in case we want to add the block rule to the "Shared" location put still push to applicable device groups.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the SecondaryDeviceGroup input in case we want to add the block rule to the "Shared" location put still push to applicable device groups.

Did you mean '...and still push to...' ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thank you, will change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed in update RN

@johnnywilkes
Copy link
Contributor Author

johnnywilkes commented Oct 16, 2023 •
edited
Loading

Thank you for the review @melamedbn! @sapirshuker, we should be good to merge

@sapirshuker sapirshuker added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Oct 17, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6624136

@sapirshuker sapirshuker merged commit 6c5cc70 into demisto:contrib/PaloAltoNetworks_PANOS-PB-EXPANDR-5997 Oct 17, 2023
@content-bot content-bot mentioned this pull request Oct 17, 2023
Merged
5 tasks
sapirshuker added a commit that referenced this pull request Oct 17, 2023
@content-bot @johnnywilkes
@ShirleyDenkberg @sapirshuker
PANOS-EXPANDR-5997 (#30218)
4fa63ca 
* PANOS-EXPANDR-5997 (#30156)

* init

* RN

* contributors

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* update RN

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix RN format

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>
sapirshuker added a commit that referenced this pull request Dec 21, 2023
@content-bot @johnnywilkes
@ShirleyDenkberg @sapirshuker
PANOS-EXPANDR-5997 (#30218)
b44632a 
* PANOS-EXPANDR-5997 (#30156)

* init

* RN

* contributors

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* update RN

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix RN format

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@sapirshuker sapirshuker sapirshuker approved these changes

@melamedbn melamedbn melamedbn approved these changes

Assignees

@melamedbn melamedbn

@sapirshuker sapirshuker

@ShirleyDenkberg ShirleyDenkberg

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johnnywilkes @content-bot @ShirleyDenkberg @melamedbn @sapirshuker