Bug fixes and enchancements in integration #30292

cyble-dev · 2023-10-18T09:51:10Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

Tests
Documentation

…ements

RosenbergYehuda · 2023-10-18T11:45:12Z

Hello @cyble-dev, thank you for your resubmission.
As you can see in the GitHub actions, in the "ci/circleci: Run Validations" section, that there are many validation failures.Do you know how to use our demisto-sdk format?
If yes, please try that and see if the errors are gone.Please check after that that everything is in the right place and working.

RosenbergYehuda · 2023-10-18T12:53:42Z

Hi, Did you run that command for each file, not only the CybleEventsV2.yml? If you look in the validation failures, you can see a recommendation the exact command to run. Scroll up and down to see all failure files, and the command to try to fix that failure. <img width="1792" alt="Screenshot 2023-10-18 at 15 50 45" src="https://github.com/demisto/content/assets/90599084/89aa2245-1d08-49b1-b594-963c8ee1a34e">

…

On Wed, Oct 18, 2023 at 3:29 PM cyble-dev ***@***.***> wrote: Hi @RosenbergYehuda <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_RosenbergYehuda&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=Cs0tnVBWQXo7TFBvK9IondKs3w-IxdW6B_rMj9Q_Kb8&m=YBtnMlIOmufY9kx7LS8NsHrdzte--zE-tflcMTvTRxuQjPul1yeDz1DRuBv8id1l&s=-UauiYnfJ5GhHc38TorEkO6dp3wmhTN496LXkM9jpjY&e=> , As per your suggestion, I checked the failing test. Before creating the PR, I have validated the files with the command: demisto-sdk format -ud -i /Users/<user_name>/Desktop/content/Packs/CybleEventsV2/Integrations/CybleEventsV2/CybleEventsV2.yml — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_30292-23issuecomment-2D1768349074&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=Cs0tnVBWQXo7TFBvK9IondKs3w-IxdW6B_rMj9Q_Kb8&m=YBtnMlIOmufY9kx7LS8NsHrdzte--zE-tflcMTvTRxuQjPul1yeDz1DRuBv8id1l&s=p4fd5aC4oR9WH2UHOCqhuyIRjeyCU2WIvlbevyfaeqQ&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVTG5LES7IKP6VH7ZL5EVBDX77DRLAVCNFSM6AAAAAA6FHBNJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRYGM2DSMBXGQ&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=Cs0tnVBWQXo7TFBvK9IondKs3w-IxdW6B_rMj9Q_Kb8&m=YBtnMlIOmufY9kx7LS8NsHrdzte--zE-tflcMTvTRxuQjPul1yeDz1DRuBv8id1l&s=XKZvGbSzbkEw-0tj1dKsfQEiqRPsqlc60oRak9sBy_w&e=> . You are receiving this because you were mentioned.Message ID: ***@***.***>

…tent into cyble-enhancements

cyble-dev · 2023-10-18T16:55:34Z

Packs/CybleEventsV2/Layouts/layoutscontainer-CybleEventsv2-Layout.json

+                "filters": [
+                    [
+                        {
+                            "left": {
+                                "isContext": true,
+                                "value": {
+                                    "simple": "eventtype"
+                                }
+                            },
+                            "operator": "isEqualString",
+                            "right": {
+                                "isContext": false,
+                                "value": {
+                                    "simple": "compromised_cards"
+                                }
+                            },
+                            "type": "shortText"
+                        }
+                    ]
+                ],


Hi @RosenbergYehuda,
As per your suggestion, I have updated all the files and fixed all the issues that were coming in ci/circleci: Run Validations section

However, I am still getting this error

[2023-10-18 15:59:47,043] [ERROR] Packs/CybleEventsV2/Layouts/layoutscontainer-CybleEventsv2-Layout.json: [ST111] - The field "filters" in path 'quickView'-> 'sections'-> 'Compromised Card Details' was not defined in the scheme [2023-10-18 15:59:47,043] [INFO] To fix the problem, try running `demisto-sdk format -i Packs/CybleEventsV2/Layouts/layoutscontainer-CybleEventsv2-Layout.json`

I was able to fix this too, but I had to remove the filter key from the layout as highlighted:
If I remove this part, then the test is passing.

But I believe this filter is required to check if the coming incident is of this particular type: 'compromised_card'. So removing this filter does not make sense. But keeping it is not letting the test pass.
I tried suggestion given with the errors too, but not working.

I have exported this layout json from XSOAR instance.

Please suggest how we can go about this.

Good job solving most of validation failures!
@melamedbn , can you please assist here?

cyble-dev · 2023-10-20T07:10:05Z

Hi @melamedbn,
Please take a look at this.

melamedbn · 2023-10-22T07:11:14Z

Hi @cyble-dev,

Everything looks great, just one fix needed:
Please remove the hardcoded values from the playbook inputs.

Best regards,
Ben

cyble-dev · 2023-10-23T05:34:02Z

Hi @melamedbn,
Can you please mention which values are you referring to?

melamedbn · 2023-10-23T08:55:05Z

Hi @melamedbn, Can you please mention which values are you referring to?

The dates in the playbook inputs.

melamedbn · 2023-10-23T11:08:56Z

Packs/CybleEventsV2/Layouts/layoutscontainer-CybleEventsv2-Layout.json

+        ]
+    },
+    "group": "incident",
+    "id": "CybleEventsv2-Layout",


Please remove the suffix -Layout

melamedbn · 2023-10-23T11:09:02Z

Packs/CybleEventsV2/Layouts/layoutscontainer-CybleEventsv2-Layout.json

+    },
+    "group": "incident",
+    "id": "CybleEventsv2-Layout",
+    "name": "CybleEventsv2-Layout",


Please remove the suffix -Layout

cyble-dev · 2023-10-23T16:29:38Z

Packs/CybleEventsV2/Playbooks/playbook-Cyble_Vision_Alert_V2.yml

    simple: "2023-05-30T00:00:00+00:00"
  required: true
  description: ""
-  playbookInputQuery: null
+  playbookInputQuery:
 - key: end_date
  value:
    simple: "2023-05-31T00:00:00+00:00"


Hi @melamedbn,
Are you talking about these dates? If yes, then I am not sure what to put here?
Does this section have same inputs as in line 53 and 61 for start and end dates?

Hi @melamedbn,
Can we please escalate this? Let me know the expected edit in above lines 124 & 130.

melamedbn · 2023-11-06T09:38:39Z

Hi @cyble-dev,

There are still things that should be addressed as discussed in our meeting.

Remove the hardcoded values from the playbook inputs.
Add description to the inputs.
Add another input for the 'limit' argument so the user will be able to choose the limit.

Best regards,
Ben

cyble-dev · 2023-11-06T09:52:30Z

Hi @melamedbn,
Can we get on a quick call right now?

cyble-dev · 2023-11-06T22:32:51Z

Hi @melamedbn,
I have made the changes you suggested. Please proceed.

cyble-dev · 2023-11-08T12:16:48Z

Hi @edik24, @melamedbn & @RosenbergYehuda,
I have removed the playbook’s changes and updated the whole pack. Please proceed.

Please let me know if you have any query.

melamedbn · 2023-11-08T12:26:48Z

Packs/CybleEventsV2/doc_files/Cyble_Vision_Alert_V2.png

Please remove the image as well

Shall I keep the empty doc_files folder or remove it as well?

melamedbn · 2023-11-08T12:34:49Z

@cyble-dev,

Just saw that the current image isn't good. so let's keep the new image and delete the old one.

cyble-dev · 2023-11-08T12:38:29Z

@cyble-dev,

Just saw that the current image isn't good. so let's keep the new image and delete the old one.

oh, okay @melamedbn
So no modification is required, right?
We are moving forward as it is now.

* Bug fixes and enchancements in integration (#30292) * New PR with all the changes * Updated RN * Fixed issues in files' format * Fixed fieldnames * Fixed field's name in layout file * Fixed field's name in layout file * Fixed field's name in layout file * Removed -Layout suffix * Updated layout file * Formatted files * Fixed playbook * Updated RNs * Made changes in object files, uploading updated ones * Formatted files and bugs, test failure fixes * Updated RN, tests, playbook changes and formatting * Updated RN --------- Co-authored-by: Yehuda Rosenberg <90599084+RosenbergYehuda@users.noreply.github.com> * RN * mistake * RN --------- Co-authored-by: cyble-dev <101622497+cyble-dev@users.noreply.github.com> Co-authored-by: Yehuda Rosenberg <90599084+RosenbergYehuda@users.noreply.github.com> Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>

cyble-dev added 2 commits October 18, 2023 15:17

New PR with all the changes

c354741

Updated RN

0e1cecc

content-bot assigned sapirshuker and melamedbn Oct 18, 2023

cyble-dev changed the title ~~Cyble enhancements~~ Bug fixes and enchancements in integration Oct 18, 2023

content-bot assigned edik24 Oct 18, 2023

RosenbergYehuda assigned RosenbergYehuda and unassigned sapirshuker Oct 18, 2023

RosenbergYehuda requested review from RosenbergYehuda and removed request for sapirshuker October 18, 2023 10:15

Merge branch 'contrib/cyble-dev_cyble-enhancements' into cyble-enhanc…

e86f5b2

…ements

RosenbergYehuda added the docs-approved label Oct 18, 2023

cyble-dev added 6 commits October 18, 2023 18:38

Fixed issues in files' format

f1a6d6e

Merge branch 'cyble-enhancements' of https://github.com/cyble-dev/con…

0181faf

…tent into cyble-enhancements

Fixed fieldnames

56a5f4f

Fixed field's name in layout file

332ba0b

Fixed field's name in layout file

fc691e7

Fixed field's name in layout file

7cce0f7

cyble-dev commented Oct 18, 2023

View reviewed changes

Merge branch 'demisto:master' into cyble-enhancements

96074b4

melamedbn reviewed Oct 23, 2023

View reviewed changes

cyble-dev commented Oct 23, 2023

View reviewed changes

Removed -Layout suffix

9961466

cyble-dev requested review from daryakoval, michal-dagan and yaakovpraisler as code owners November 5, 2023 20:32

daryakoval removed request for yucohen and daryakoval November 5, 2023 20:34

yaakovpraisler removed their request for review November 5, 2023 20:36

RosenbergYehuda removed request for dansterenson, michalgold, idovandijk, Ni-Knight, ilaner, dorschw and michal-dagan November 8, 2023 09:14

cyble-dev and others added 3 commits November 8, 2023 17:18

Updated RN, tests, playbook changes and formatting

1735951

Updated RN

cc2ef8f

Merge branch 'demisto:master' into cyble-enhancements

bf64e77

melamedbn reviewed Nov 8, 2023

View reviewed changes

melamedbn approved these changes Nov 8, 2023

View reviewed changes

RosenbergYehuda approved these changes Nov 8, 2023

View reviewed changes

RosenbergYehuda merged commit 00e6480 into demisto:contrib/cyble-dev_cyble-enhancements Nov 8, 2023
18 of 19 checks passed

cyble-dev deleted the cyble-enhancements branch November 9, 2023 10:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug fixes and enchancements in integration #30292

Bug fixes and enchancements in integration #30292

cyble-dev commented Oct 18, 2023 •

edited

Loading

RosenbergYehuda commented Oct 18, 2023 •

edited

Loading

RosenbergYehuda commented Oct 18, 2023 via email •

edited

Loading

cyble-dev Oct 18, 2023 •

edited

Loading

RosenbergYehuda Oct 18, 2023 •

edited

Loading

cyble-dev commented Oct 20, 2023

melamedbn commented Oct 22, 2023

cyble-dev commented Oct 23, 2023

melamedbn commented Oct 23, 2023

melamedbn Oct 23, 2023

melamedbn Oct 23, 2023

cyble-dev Oct 23, 2023

cyble-dev Oct 25, 2023

melamedbn commented Nov 6, 2023

cyble-dev commented Nov 6, 2023

cyble-dev commented Nov 6, 2023

cyble-dev commented Nov 8, 2023

melamedbn Nov 8, 2023

cyble-dev Nov 8, 2023

melamedbn commented Nov 8, 2023

cyble-dev commented Nov 8, 2023 •

edited

Loading

Bug fixes and enchancements in integration #30292

Bug fixes and enchancements in integration #30292

Conversation

cyble-dev commented Oct 18, 2023 • edited Loading

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Must have

RosenbergYehuda commented Oct 18, 2023 • edited Loading

RosenbergYehuda commented Oct 18, 2023 via email • edited Loading

cyble-dev Oct 18, 2023 • edited Loading

Choose a reason for hiding this comment

RosenbergYehuda Oct 18, 2023 • edited Loading

Choose a reason for hiding this comment

cyble-dev commented Oct 20, 2023

melamedbn commented Oct 22, 2023

cyble-dev commented Oct 23, 2023

melamedbn commented Oct 23, 2023

melamedbn Oct 23, 2023

Choose a reason for hiding this comment

melamedbn Oct 23, 2023

Choose a reason for hiding this comment

cyble-dev Oct 23, 2023

Choose a reason for hiding this comment

cyble-dev Oct 25, 2023

Choose a reason for hiding this comment

melamedbn commented Nov 6, 2023

cyble-dev commented Nov 6, 2023

cyble-dev commented Nov 6, 2023

cyble-dev commented Nov 8, 2023

melamedbn Nov 8, 2023

Choose a reason for hiding this comment

cyble-dev Nov 8, 2023

Choose a reason for hiding this comment

melamedbn commented Nov 8, 2023

cyble-dev commented Nov 8, 2023 • edited Loading

cyble-dev commented Oct 18, 2023 •

edited

Loading

RosenbergYehuda commented Oct 18, 2023 •

edited

Loading

RosenbergYehuda commented Oct 18, 2023 via email •

edited

Loading

cyble-dev Oct 18, 2023 •

edited

Loading

RosenbergYehuda Oct 18, 2023 •

edited

Loading

cyble-dev commented Nov 8, 2023 •

edited

Loading