Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - EXPANDER - 4378 - NotificationTicketType Input for ServiceNow #30322

Conversation

BigEasyJ
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

EXPANDR-4378

Description

Updated playbooks to use new playbook input, NotificationTicketType, for ServiceNow ticket type.

Must have

  • Tests
  • Documentation

@BigEasyJ BigEasyJ marked this pull request as draft October 19, 2023 19:31
@BigEasyJ BigEasyJ changed the title Expandr 4378 [ASM] - EXPANDER - 4378 - NotificationTicketType Input for ServiceNow Oct 19, 2023
value:
simple: incident
required: true
description: The ticket type used by ticketing systems. The default is "incident" because ticketing systems such as ServiceNow and Cherwell use it as default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: if we could have links to different types for SNOW and Jira, that would be helpful

Copy link
Contributor Author

@BigEasyJ BigEasyJ Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there such a resource? For Jira and ServiceNow they are both customizable so there is not a published list for either that I have seen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies, I thought there were defined lists

@melamedbn melamedbn removed their request for review October 22, 2023 07:12
@BigEasyJ BigEasyJ marked this pull request as ready for review October 23, 2023 20:10
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigEasyJ , good stuff!

@ilappe
Copy link
Contributor

ilappe commented Oct 29, 2023

Hi @johnnywilkes
are this ready for XSOAR review?

@ilappe
Copy link
Contributor

ilappe commented Nov 1, 2023

Hi @BigEasyJ
what's the status here?

@ilappe
Copy link
Contributor

ilappe commented Nov 5, 2023

@BigEasyJ @johnnywilkes
a gentleman reminder...

@ilappe
Copy link
Contributor

ilappe commented Nov 7, 2023

as discussed in Slack
this are ready to merge
i will fix the validation issue in the internal PR

@melamedbn melamedbn removed their assignment Nov 7, 2023
@BigEasyJ
Copy link
Contributor Author

BigEasyJ commented Nov 7, 2023

Conflicts have been fixed and merged 👍🏽

@ilappe ilappe merged commit eb02303 into demisto:contrib/PaloAltoNetworks_EXPANDR-4378 Nov 7, 2023
17 of 20 checks passed
ilappe added a commit that referenced this pull request Nov 8, 2023
…#30732)

* [ASM] - EXPANDER - 4378 - NotificationTicketType Input for ServiceNow (#30322)

* Add NotificationTicketType input

* Update readme files

* Add Release Notes

* Update Release Notes

* update RN

* update RN

* update version

* update version to 1.7.11

---------

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: ilappe <ilappe@paloaltonetworks.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
…#30732)

* [ASM] - EXPANDER - 4378 - NotificationTicketType Input for ServiceNow (#30322)

* Add NotificationTicketType input

* Update readme files

* Add Release Notes

* Update Release Notes

* update RN

* update RN

* update version

* update version to 1.7.11

---------

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: ilappe <ilappe@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants