Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claroty-CTD-Modeling-Rules-CIAC-7022 #30343

Merged
merged 29 commits into from
Nov 7, 2023

Conversation

cweltPA
Copy link
Contributor

@cweltPA cweltPA commented Oct 23, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-7022

Description

This PR contains XSIAM Modeling Rules content for the Claroty CTD (Continuous Threat Detection) pack.

Must have

  • Tests
  • Documentation

@github-actions
Copy link

Your contributed Claroty pack has been modified on files:

Packs/Claroty/ModelingRules/Claroty/Claroty.xif
Packs/Claroty/ModelingRules/Claroty/Claroty.yml
Packs/Claroty/ModelingRules/Claroty/Claroty_schema.json
Please review the changes here

@cweltPA cweltPA marked this pull request as ready for review October 25, 2023 09:50
@cweltPA cweltPA self-assigned this Oct 25, 2023
@cweltPA cweltPA marked this pull request as draft October 25, 2023 12:08
@ShirleyDenkberg ShirleyDenkberg self-assigned this Oct 25, 2023
@ShirleyDenkberg
Copy link
Contributor

@eepstain Doc review completed.

cweltPA and others added 8 commits October 25, 2023 19:26
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@cweltPA cweltPA marked this pull request as ready for review October 26, 2023 07:13
@cweltPA cweltPA closed this Nov 2, 2023
@cweltPA cweltPA reopened this Nov 2, 2023
@cweltPA
Copy link
Contributor Author

cweltPA commented Nov 6, 2023

@ShirleyDenkberg
I added a small disclaimer on top of the XSIAM section on the README,
if you can review it once again

@ShirleyDenkberg
Copy link
Contributor

@cweltPA Looks OK.

@cweltPA cweltPA merged commit 24585f2 into master Nov 7, 2023
@cweltPA cweltPA deleted the ciac-7022-xsiam-claroty-ctd-modeling branch November 7, 2023 04:54
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* init-modeling-rules

* enrich-modeling-rules

* modeling-rules

* update-README.md

* update pack keywords

* update-release-notes

* update-modeling-rules

* add-known-words

* refactor-modeling-rules

* Update Packs/Claroty/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Claroty/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Claroty/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix-README.md-table

* refactor-modeling-rules

* add-disclaimer-on-README.md

* add-disclaimer-on-README.md

* Update README.md

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants