Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made premium packs free. Added new alert states to the Code42 Check I… #30361

Merged

Conversation

jdullum
Copy link
Contributor

@jdullum jdullum commented Oct 23, 2023

…ncydr Status And Close XSOAR Incident playbook. Deprecated commands.

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

The main goal of this PR is to move the playbooks from the Code42 Insider Threat Remediation premium pack to the Code42 free pack. It also fixes a minor bug with the "Check Incydr Status and Close XSOAR Incident" playbook, and deprecates commands that are no longer supported.

Must have

  • Tests
  • Documentation

…ncydr Status And Close XSOAR Incident playbook. Deprecated commands.
@jdullum jdullum requested a review from ostolero as a code owner October 23, 2023 22:30
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Oct 23, 2023
@content-bot content-bot changed the base branch from master to contrib/code42_Code42_paid_to_free October 23, 2023 22:31
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdullum for your great effort in this contribution!
i reviewed the code related files, please see my few comments
in addition please note the validation error

@melamedbn will review the playbooks etc.

@ilappe ilappe added the pending-contributor The PR is pending the response of its creator label Oct 25, 2023
Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdullum, great work!
@melamedbn, did you finish with the review?

@jdullum jdullum requested a review from yucohen as a code owner October 30, 2023 14:32
@ilappe ilappe removed request for ostolero and yucohen October 30, 2023 21:18
@jdullum jdullum requested a review from dorschw as a code owner October 31, 2023 21:21
@ilappe ilappe added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Nov 5, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6801924

@ilappe
Copy link
Contributor

ilappe commented Nov 6, 2023

pre commit fail due to change in gitlab files, will be fixed in the internal PR

@ilappe ilappe merged commit 4be2f04 into demisto:contrib/code42_Code42_paid_to_free Nov 6, 2023
ilappe added a commit that referenced this pull request Nov 6, 2023
#30361) (#30691)

* Made premium packs free. Added new alert states to the Code42 Check Incydr Status And Close XSOAR Incident playbook. Deprecated commands.

* Removed more unused methods and added tests to get back above the 90% threshold.

* Updated playbooks to use non-deprecated commands

Co-authored-by: jdullum <jdullum@users.noreply.github.com>
Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
#30361) (#30691)

* Made premium packs free. Added new alert states to the Code42 Check Incydr Status And Close XSOAR Incident playbook. Deprecated commands.

* Removed more unused methods and added tests to get back above the 90% threshold.

* Updated playbooks to use non-deprecated commands

Co-authored-by: jdullum <jdullum@users.noreply.github.com>
Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants