Made premium packs free. Added new alert states to the Code42 Check I… #30361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncydr Status And Close XSOAR Incident playbook. Deprecated commands.
|
|
ilappe
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Thanks @jdullum for your great effort in this contribution!
i reviewed the code related files, please see my few comments
in addition please note the validation error
@melamedbn will review the playbooks etc.
ilappe
added
the
pending-contributor
ilappe
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
Thanks @jdullum, great work!
@melamedbn, did you finish with the review?
jdullum
requested review from
daryakoval,
amshamah419,
thefrieddan1 and
dorschw
as code owners
melamedbn
approved these changes
Nov 5, 2023
ilappe
added
the
ready-for-instance-test
|
pre commit fail due to change in gitlab files, will be fixed in the internal PR |
ilappe
merged commit 4be2f04
into
demisto:contrib/code42_Code42_paid_to_free
19 of 22 checks passed
ilappe
added a commit
that referenced
this pull request
Nov 6, 2023
#30361) (#30691) * Made premium packs free. Added new alert states to the Code42 Check Incydr Status And Close XSOAR Incident playbook. Deprecated commands. * Removed more unused methods and added tests to get back above the 90% threshold. * Updated playbooks to use non-deprecated commands Co-authored-by: jdullum <jdullum@users.noreply.github.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
#30361) (#30691) * Made premium packs free. Added new alert states to the Code42 Check Incydr Status And Close XSOAR Incident playbook. Deprecated commands. * Removed more unused methods and added tests to get back above the 90% threshold. * Updated playbooks to use non-deprecated commands Co-authored-by: jdullum <jdullum@users.noreply.github.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ncydr Status And Close XSOAR Incident playbook. Deprecated commands.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
The main goal of this PR is to move the playbooks from the Code42 Insider Threat Remediation premium pack to the Code42 free pack. It also fixes a minor bug with the "Check Incydr Status and Close XSOAR Incident" playbook, and deprecates commands that are no longer supported.
Must have