XSOAR EDL Checker - Add support for XSOAR 8.x - Oct 2023 #30539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @beauchompers,
Thank you for your contribution!
Good work :)
Plesae see my comments.
Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again
MosheEichler
added
the
pending-contributor
…into xsoar_edl_checker_update_oct2023
MosheEichler
approved these changes
Nov 5, 2023
MosheEichler
merged commit 01094e9
into
demisto:contrib/beauchompers_xsoar_edl_checker_update_oct2023
17 of 20 checks passed
MosheEichler
added a commit
that referenced
this pull request
Nov 7, 2023
* XSOAR EDL Checker - Add support for XSOAR 8.x - Oct 2023 (#30539) * after format * updated description, integration readme, and increased pack version * updating pack metadata to use my Palo Alto information * updated readme for integration --------- Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * remove hourly * add image * docker image * RN * docker * period * RN --------- Co-authored-by: Mike Beauchamp <beauchompers@gmail.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* XSOAR EDL Checker - Add support for XSOAR 8.x - Oct 2023 (#30539) * after format * updated description, integration readme, and increased pack version * updating pack metadata to use my Palo Alto information * updated readme for integration --------- Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * remove hourly * add image * docker image * RN * docker * period * RN --------- Co-authored-by: Mike Beauchamp <beauchompers@gmail.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: N/A
Description
Added support to check EDLs hosted on XSOAR 8.x, and fixed an issue with the playbook where the conditional was looking at the wrong output to determine if any EDLs were failing.
Must have