Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW add custom resolution code parameter #30599

Merged
merged 25 commits into from
Nov 9, 2023
Merged

Conversation

MosheEichler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-8773

Description

Added a new parameter to enable mirroring the resolution code from SNOW to the close reason of XSOAR.

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler self-assigned this Nov 1, 2023
Copy link
Contributor

@omerKarkKatz omerKarkKatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
If the user will configure both server_custom_close_code and server_close_custom_state.
We will use the close code.
Should we allow configuring both or throw an exception?

@ShirleyDenkberg
Copy link
Contributor

@RotemAmit @omerKarkKatz Doc review completed.

MosheEichler and others added 4 commits November 7, 2023 17:07
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@MosheEichler MosheEichler merged commit 7bf936e into master Nov 9, 2023
14 checks passed
@MosheEichler MosheEichler deleted the service-now-close-code branch November 9, 2023 08:15
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* sysparm_query

* default get

* fix

* update the integration to support custom close reason

* revert changes

* revert changes

* RN

* docker

* UT

* ignore flake8 error

* docs

* Update Packs/ServiceNow/ReleaseNotes/2_5_45.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ServiceNow/Integrations/ServiceNowv2/ServiceNowv2.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ServiceNow/Integrations/ServiceNowv2/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* overwrites

* custom

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants