Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve email squatting script faster #30615

Merged
merged 8 commits into from
Nov 6, 2023

Conversation

anara123
Copy link
Contributor

@anara123 anara123 commented Nov 1, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Replace the email squatting implementation, instead of using execute_command, use vanilla JS

Must have

  • Tests
  • Documentation

@anara123 anara123 requested a review from glicht November 1, 2023 21:23
@glicht glicht self-assigned this Nov 6, 2023
Copy link
Contributor

@glicht glicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@anara123 anara123 merged commit b29e7fa into master Nov 6, 2023
18 checks passed
@anara123 anara123 deleted the improve-email-domain-squatting-faster branch November 6, 2023 12:26
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* improve email squatting script faster

* format yml

* format script

* Bump pack from version CommonScripts to 1.12.40.

* remove usage of Array.from since it is not supported in 6.9

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants