Edl enhancements #30664
Merged
Edl enhancements #30664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeanArbel
approved these changes
Nov 6, 2023
| @@ -17,8 +17,7 @@ configuration: | |||
| display: Indicator Query | |||
| name: indicators_query | |||
| type: 0 | |||
| section: Collect | |||
| advanced: true | |||
| advanced: false | |||
| @@ -82,6 +83,8 @@ configuration: | |||
| type: 9 | |||
| section: Connect | |||
| required: false | |||
| hidden: | |||
| - marketplacev2 | |||
There was a problem hiding this comment.
Have you tested this?
Last time I checked this wasn't showing as expected.
There was a problem hiding this comment.
tested in xsoar saas:
|
|
||
| - Undeprecated the *Legacy Query* parameter. | ||
| - Removed *Listen Port* and *credentials* parameters from cortex XSIAM. | ||
| - Move out from `Advanced settings` the *query* parameter. |
There was a problem hiding this comment.
I am not sure what this means? Is it no longer part of the Advanced settings but it is part of the regular settings? Was it just removed?
There was a problem hiding this comment.
It means that the Indicator Query params was inside the Advanced settings and now we move it out from there to Collect section
|
@DeanArbel Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* edl enhancements * update RN * update hidden value update RN * add xsoar_saas to hidden * Update Packs/EDL/ReleaseNotes/3_2_13.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Advanced settingsthe query parameter.Must have