Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upload Flow Ref] Remove filtering packs by marketplace #30667

Merged
merged 9 commits into from
Nov 7, 2023
Merged

[Upload Flow Ref] Remove filtering packs by marketplace #30667

merged 9 commits into from
Nov 7, 2023

Conversation

yaakovpraisler
Copy link
Contributor

@yaakovpraisler yaakovpraisler commented Nov 5, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Remove the logic of filtering packs by the marketplace, This is not needed anymore as this is calculated in graph creation.
  • Added a test upload case where uploading an only XSOAR pack - verify it's not in XSIAM bucket.

@yaakovpraisler yaakovpraisler removed the request for review from ilaner November 5, 2023 22:30
dantavori
dantavori approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@yaakovpraisler yaakovpraisler merged commit e5a9040 into master Nov 7, 2023
14 checks passed
@yaakovpraisler yaakovpraisler deleted the UFR-remove-filter-by-marketplace branch November 7, 2023 20:30
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
@yaakovpraisler
[Upload Flow Ref] Remove filtering packs by marketplace (#30667)
ff1da55 
* remove filtering packs by marketplace

* add load_user_metadata

* revert removing filter by id set

* add test upload case

* fix new XSOAR pack in test upload

* fix
israelpoli pushed a commit that referenced this pull request May 15, 2024
@yaakovpraisler
[Upload Flow Ref] Remove filtering packs by marketplace (#30667)
e3d1a21 
* remove filtering packs by marketplace

* add load_user_metadata

* revert removing filter by id set

* add test upload case

* fix new XSOAR pack in test upload

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantavori dantavori dantavori approved these changes

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaakovpraisler @dantavori