Fix server numeric version #30699
Merged
Fix server numeric version #30699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyAfik
requested review from
daryakoval,
michal-dagan,
dorschw and
yaakovpraisler
as code owners
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* add default * fix collect tests not find serverMinVersion in metadata * change logic of get_server_numeric_version to use api * pre-commit * ut * uts and test fix works * pre-commit * fix validate premium packs * fix uts * test also pan-os and qradar * remove tested packs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
Before reviewing please read issue's solution (in jira)
fixes: link to the issue
Builds
build where ctf-01 pack is not installed in xsoar-6 at all, but is installed in xsoar-8
build where checking pan-os, qradar and ctf-01 packs showing that ctf-01 pack is installed only in xsoar-ng, while pan-os and qradar are installed in both xsoar-6 and xsoar-ng
the log
can be found in xsoar-6 jobs which means that it won't be installed over these servers
Description
serverMinVersionfrompackmetadata.json, so for example if serverMinVersion in packmetadata is "8.2.0", it would still try to install the pack on XSOAR-6 master.get_server_numeric_versionto use the api to retrieve the correct server version.Must have