Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the check validating build files are up to date #30703

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fixing the check validating build files are up to date #30703

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4896e22
fixing the check validating build files are up to date
Nov 6, 2023
3413826
Merge branch 'master' into check_build_files_are_up_to_date
kobymeir Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitlab/ci/.gitlab-ci.global.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
.check_build_files_are_up_to_date: &check_build_files_are_up_to_date
- section_start "Check Build Files Are Up To Date"
- |
if [[ -n "${DEMISTO_SDK_NIGHTLY}" || -n "${NIGHTLY}" || -n "${BUCKET_UPLOAD}" || -n "${SLACK_JOB}" ]]; then
echo "running nightly or bucket upload, skipping files up-to-date validation"
if [[ -n "${DEMISTO_SDK_NIGHTLY}" ]] || [[ -n "${NIGHTLY}" ]] || [[ -n "${BUCKET_UPLOAD}" ]] || [[ -n "${SLACK_JOB}" ]] || [[ "${BUILD_MACHINES_CLEANUP}" == "true" ]] || [[ "${DELETE_MISMATCHED_BRANCHES}" == "true" ]] || [[ "${SECURITY_SCANS}" == "true" ]] || [[ "${DEMISTO_TEST_NATIVE_CANDIDATE}" == "true" ]] || [[ "${CI_COMMIT_BRANCH}" == "master" ]]; then
echo "Running a build which doesn't require build files check validation"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we print the values of all these variables, so we could be certain why we didn't check the validation of the build files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are printed in the build parameters step

else
./Tests/scripts/is_file_up_to_date.sh .gitlab $CI_COMMIT_BRANCH
# we want to checkout if it's not up-to-date
Expand Down
Loading