Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRadar: update conf file with instance name #30743

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

ilappe
Copy link
Contributor

@ilappe ilappe commented Nov 8, 2023

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-8788

Description

put the relevant instance name in conf file as there is one new secret which cause the integration to fail

@ilappe ilappe requested a review from esharf November 8, 2023 10:05
@ilappe ilappe requested a review from michal-dagan as a code owner November 8, 2023 10:05
@ilappe ilappe self-assigned this Nov 8, 2023
@ilappe ilappe merged commit 4c95294 into master Nov 8, 2023
19 checks passed
@ilappe ilappe deleted the ilappe/CIAC-8654/fix_conf_file branch November 8, 2023 10:44
MosheEichler pushed a commit that referenced this pull request Nov 8, 2023
MosheEichler pushed a commit that referenced this pull request Nov 8, 2023
MosheEichler added a commit that referenced this pull request Nov 12, 2023
…perators in filter (#30513)

* [Microsoft Defender for Endpoint]: Fix bug be able to use different operators in filter  (#30481)

* Fix: add filter arg to be able to filter on the date

* update realase note after rebase

* applying changes after review

* SysAid add get file (#30718)

* SysAid add get file (#30583)

* SysAid add get file

* Fixed error SysAid add get file

* docker

* Add file output

* Update Packs/SysAid/ReleaseNotes/1_0_13.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/SysAid.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/SysAid.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fixed UT

---------

Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* update conf file (#30743)

* remove/change values (#30728)

* SentinelOne v 3 2 12 (#30740)

* SentinelOne v 3 2 12 (#30626)

* Bug Fixes

* updated the docker image

* updated the release notes

* making chages in threat request call

* review comment fix

* fixed release notes

* docker

---------

Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>

* Netcraft Revamp (#29527)

* init

* started fetch

* finished fetch

* name changes

* fixed output in yml

* added command names

* mirroring part 1

* added incident type

* fixed incident type

* fethcing logic works!

* cmnd: netcraft-attack-report

* cmnd: netcraft-attack-report complete

* reference new pack in old

* cmnd: netcraft-attack-report complete

* session changes

* added classifier

* added commands

* commands continued

* commands continued

* order change

* test-module

* examples init

* session changes

* pre update

* finished code

* added TPB

* unit-tests init

* test_data TO BE DELETED

* test_data TO BE DELETED

* test_data complete

* test_data.py complete

* unit-tests continued

* unit-tests complete

* fixed KeyError bug

* fixed SubmissionNextToken bug

* fixed pagination bug

* remove unused test data

* improved UI

* silence secret ignore

* silence line-too-long

* silence secret ignore

* added readme; fixed png

* tests/format complete

* default args

* session changes

* session changes

* CR changes

* finished docs

* fix docs

* fix docs

* added layout

* clearer description

* add error for no file

* add error for no file

* demo changes part 1

* demo changes part 2

* demo changes part 3

* demo changes part 4

* demo changes part 5

* fixed unit-tests

* update escalate docs

* authorise => authorize

* match case => if-elif

* CR changes

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fixed unit-tests

* remove trailing whitespace

* try running build

* fixed upload bug

* name change to avoid conflict

* pack readme part 1

* release notes

* add image

* removed unnecessary files

* cleaned build problems

* pack readme part 2

* readme complete

* readme complete

* added layout, mapper, type; not formatted

* capitalize 'service'

* get_file_path

* trial fix for unittests

* fixed unit-tests

* update docker

* small changes

* doc review changes

* update TPB

* silence secret detections

* classifier fixed

* demo changes

* demo changes

* small change

* UI works

* fix tests and docs

* update docker

* added types to yaml

* fixed file submit bug

* layout for xsoar only

* build wars: round 1

* build wars: round 2

* build wars: round 3

* build wars: round 4

* build wars: round 5

* build wars: round 6

* build wars: round 7

* Update conf.json

* remove email address

* fix TPB

* incease retry-interval

* raised timeout threshold

* update docker

* raised from_version

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* docker

* conflicts

---------

Co-authored-by: pl-brault <143391737+pl-brault@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com>
MosheEichler added a commit that referenced this pull request Nov 16, 2023
* fix added warning IP list too large (#30217)

* fix added warning

* Added fqdn parameter to qualys-schedule-scan-create command

* flake8

* pre commit

* RN

* Update Packs/qualys/ReleaseNotes/2_0_6.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix description

* docker

* RN

* SysAid add get file (#30718)

* SysAid add get file (#30583)

* SysAid add get file

* Fixed error SysAid add get file

* docker

* Add file output

* Update Packs/SysAid/ReleaseNotes/1_0_13.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/SysAid.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/SysAid.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fixed UT

---------

Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* update conf file (#30743)

* remove/change values (#30728)

* SentinelOne v 3 2 12 (#30740)

* SentinelOne v 3 2 12 (#30626)

* Bug Fixes

* updated the docker image

* updated the release notes

* making chages in threat request call

* review comment fix

* fixed release notes

* docker

---------

Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>

* Netcraft Revamp (#29527)

* init

* started fetch

* finished fetch

* name changes

* fixed output in yml

* added command names

* mirroring part 1

* added incident type

* fixed incident type

* fethcing logic works!

* cmnd: netcraft-attack-report

* cmnd: netcraft-attack-report complete

* reference new pack in old

* cmnd: netcraft-attack-report complete

* session changes

* added classifier

* added commands

* commands continued

* commands continued

* order change

* test-module

* examples init

* session changes

* pre update

* finished code

* added TPB

* unit-tests init

* test_data TO BE DELETED

* test_data TO BE DELETED

* test_data complete

* test_data.py complete

* unit-tests continued

* unit-tests complete

* fixed KeyError bug

* fixed SubmissionNextToken bug

* fixed pagination bug

* remove unused test data

* improved UI

* silence secret ignore

* silence line-too-long

* silence secret ignore

* added readme; fixed png

* tests/format complete

* default args

* session changes

* session changes

* CR changes

* finished docs

* fix docs

* fix docs

* added layout

* clearer description

* add error for no file

* add error for no file

* demo changes part 1

* demo changes part 2

* demo changes part 3

* demo changes part 4

* demo changes part 5

* fixed unit-tests

* update escalate docs

* authorise => authorize

* match case => if-elif

* CR changes

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fixed unit-tests

* remove trailing whitespace

* try running build

* fixed upload bug

* name change to avoid conflict

* pack readme part 1

* release notes

* add image

* removed unnecessary files

* cleaned build problems

* pack readme part 2

* readme complete

* readme complete

* added layout, mapper, type; not formatted

* capitalize 'service'

* get_file_path

* trial fix for unittests

* fixed unit-tests

* update docker

* small changes

* doc review changes

* update TPB

* silence secret detections

* classifier fixed

* demo changes

* demo changes

* small change

* UI works

* fix tests and docs

* update docker

* added types to yaml

* fixed file submit bug

* layout for xsoar only

* build wars: round 1

* build wars: round 2

* build wars: round 3

* build wars: round 4

* build wars: round 5

* build wars: round 6

* build wars: round 7

* Update conf.json

* remove email address

* fix TPB

* incease retry-interval

* raised timeout threshold

* update docker

* raised from_version

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* docker

* change map

* change scan

* revert

---------

Co-authored-by: franciscojoseabellan <134506710+franciscojoseabellan@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com>
Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
…perators in filter (#30513)

* [Microsoft Defender for Endpoint]: Fix bug be able to use different operators in filter  (#30481)

* Fix: add filter arg to be able to filter on the date

* update realase note after rebase

* applying changes after review

* SysAid add get file (#30718)

* SysAid add get file (#30583)

* SysAid add get file

* Fixed error SysAid add get file

* docker

* Add file output

* Update Packs/SysAid/ReleaseNotes/1_0_13.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/SysAid.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/SysAid.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fixed UT

---------

Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* update conf file (#30743)

* remove/change values (#30728)

* SentinelOne v 3 2 12 (#30740)

* SentinelOne v 3 2 12 (#30626)

* Bug Fixes

* updated the docker image

* updated the release notes

* making chages in threat request call

* review comment fix

* fixed release notes

* docker

---------

Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>

* Netcraft Revamp (#29527)

* init

* started fetch

* finished fetch

* name changes

* fixed output in yml

* added command names

* mirroring part 1

* added incident type

* fixed incident type

* fethcing logic works!

* cmnd: netcraft-attack-report

* cmnd: netcraft-attack-report complete

* reference new pack in old

* cmnd: netcraft-attack-report complete

* session changes

* added classifier

* added commands

* commands continued

* commands continued

* order change

* test-module

* examples init

* session changes

* pre update

* finished code

* added TPB

* unit-tests init

* test_data TO BE DELETED

* test_data TO BE DELETED

* test_data complete

* test_data.py complete

* unit-tests continued

* unit-tests complete

* fixed KeyError bug

* fixed SubmissionNextToken bug

* fixed pagination bug

* remove unused test data

* improved UI

* silence secret ignore

* silence line-too-long

* silence secret ignore

* added readme; fixed png

* tests/format complete

* default args

* session changes

* session changes

* CR changes

* finished docs

* fix docs

* fix docs

* added layout

* clearer description

* add error for no file

* add error for no file

* demo changes part 1

* demo changes part 2

* demo changes part 3

* demo changes part 4

* demo changes part 5

* fixed unit-tests

* update escalate docs

* authorise => authorize

* match case => if-elif

* CR changes

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fixed unit-tests

* remove trailing whitespace

* try running build

* fixed upload bug

* name change to avoid conflict

* pack readme part 1

* release notes

* add image

* removed unnecessary files

* cleaned build problems

* pack readme part 2

* readme complete

* readme complete

* added layout, mapper, type; not formatted

* capitalize 'service'

* get_file_path

* trial fix for unittests

* fixed unit-tests

* update docker

* small changes

* doc review changes

* update TPB

* silence secret detections

* classifier fixed

* demo changes

* demo changes

* small change

* UI works

* fix tests and docs

* update docker

* added types to yaml

* fixed file submit bug

* layout for xsoar only

* build wars: round 1

* build wars: round 2

* build wars: round 3

* build wars: round 4

* build wars: round 5

* build wars: round 6

* build wars: round 7

* Update conf.json

* remove email address

* fix TPB

* incease retry-interval

* raised timeout threshold

* update docker

* raised from_version

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* docker

* conflicts

---------

Co-authored-by: pl-brault <143391737+pl-brault@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* fix added warning IP list too large (#30217)

* fix added warning

* Added fqdn parameter to qualys-schedule-scan-create command

* flake8

* pre commit

* RN

* Update Packs/qualys/ReleaseNotes/2_0_6.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix description

* docker

* RN

* SysAid add get file (#30718)

* SysAid add get file (#30583)

* SysAid add get file

* Fixed error SysAid add get file

* docker

* Add file output

* Update Packs/SysAid/ReleaseNotes/1_0_13.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/SysAid.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/SysAid.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/SysAid/Integrations/SysAid/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fixed UT

---------

Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* update conf file (#30743)

* remove/change values (#30728)

* SentinelOne v 3 2 12 (#30740)

* SentinelOne v 3 2 12 (#30626)

* Bug Fixes

* updated the docker image

* updated the release notes

* making chages in threat request call

* review comment fix

* fixed release notes

* docker

---------

Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>

* Netcraft Revamp (#29527)

* init

* started fetch

* finished fetch

* name changes

* fixed output in yml

* added command names

* mirroring part 1

* added incident type

* fixed incident type

* fethcing logic works!

* cmnd: netcraft-attack-report

* cmnd: netcraft-attack-report complete

* reference new pack in old

* cmnd: netcraft-attack-report complete

* session changes

* added classifier

* added commands

* commands continued

* commands continued

* order change

* test-module

* examples init

* session changes

* pre update

* finished code

* added TPB

* unit-tests init

* test_data TO BE DELETED

* test_data TO BE DELETED

* test_data complete

* test_data.py complete

* unit-tests continued

* unit-tests complete

* fixed KeyError bug

* fixed SubmissionNextToken bug

* fixed pagination bug

* remove unused test data

* improved UI

* silence secret ignore

* silence line-too-long

* silence secret ignore

* added readme; fixed png

* tests/format complete

* default args

* session changes

* session changes

* CR changes

* finished docs

* fix docs

* fix docs

* added layout

* clearer description

* add error for no file

* add error for no file

* demo changes part 1

* demo changes part 2

* demo changes part 3

* demo changes part 4

* demo changes part 5

* fixed unit-tests

* update escalate docs

* authorise => authorize

* match case => if-elif

* CR changes

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fixed unit-tests

* remove trailing whitespace

* try running build

* fixed upload bug

* name change to avoid conflict

* pack readme part 1

* release notes

* add image

* removed unnecessary files

* cleaned build problems

* pack readme part 2

* readme complete

* readme complete

* added layout, mapper, type; not formatted

* capitalize 'service'

* get_file_path

* trial fix for unittests

* fixed unit-tests

* update docker

* small changes

* doc review changes

* update TPB

* silence secret detections

* classifier fixed

* demo changes

* demo changes

* small change

* UI works

* fix tests and docs

* update docker

* added types to yaml

* fixed file submit bug

* layout for xsoar only

* build wars: round 1

* build wars: round 2

* build wars: round 3

* build wars: round 4

* build wars: round 5

* build wars: round 6

* build wars: round 7

* Update conf.json

* remove email address

* fix TPB

* incease retry-interval

* raised timeout threshold

* update docker

* raised from_version

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* docker

* change map

* change scan

* revert

---------

Co-authored-by: franciscojoseabellan <134506710+franciscojoseabellan@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com>
Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants