Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dbot closed incidents percentage script #31093

Merged
merged 9 commits into from
Nov 26, 2023
Merged

Fix dbot closed incidents percentage script #31093

merged 9 commits into from
Nov 26, 2023

Conversation

MosheEichler
Copy link
Contributor

@MosheEichler MosheEichler commented Nov 23, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-8992

Description

Updated the query in DBotClosedIncidentsPercentage script to status:closed and closingUser:DBot

I created a dashboard (ask @liorblob for access permission) in order to test the fix.

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler changed the title Fix d bot closed incidents percentage script Fix dbot closed incidents percentage script Nov 23, 2023
@MosheEichler MosheEichler requested a review from ilappe November 23, 2023 15:39
@ShirleyDenkberg
Copy link
Contributor

@anara123 @ilappe Doc review completed.

MosheEichler and others added 2 commits November 24, 2023 09:11
@MosheEichler @ShirleyDenkberg
Update Packs/CommonScripts/ReleaseNotes/1_12_47.md
5cfcb36 
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@MosheEichler
Merge branch 'master' into fix-DBotClosedIncidentsPercetage-script
4901845
DeanArbel
DeanArbel approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.12.48.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@MosheEichler MosheEichler added the ForceMerge Forcing the merge of the PR despite the build status label Nov 26, 2023
@MosheEichler
Copy link
Contributor Author

@DeanArbel needs a force merge since it fails on no tests (UT, TPB) where found (it's a short JS script)

@DeanArbel DeanArbel merged commit d0fcdcb into master Nov 26, 2023
15 of 16 checks passed
@DeanArbel DeanArbel deleted the fix-DBotClosedIncidentsPercetage-script branch November 26, 2023 12:33
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
@MosheEichler @ShirleyDenkberg
Fix dbot closed incidents percentage script (#31093)
e874084 
* Fixed DBotClosedIncidentsPercentage script query

* RN

* format

* RN

* Update Packs/CommonScripts/ReleaseNotes/1_12_47.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Bump pack from version CommonScripts to 1.12.48.

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@DeanArbel DeanArbel DeanArbel approved these changes

@anara123 anara123 Awaiting requested review from anara123

@ilappe ilappe Awaiting requested review from ilappe

Assignees

@ShirleyDenkberg ShirleyDenkberg

@MosheEichler MosheEichler

Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MosheEichler @ShirleyDenkberg @content-bot @DeanArbel