Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CommonServerPython] Fix Polling Failure If polling Parameter is Missing #31111

Merged
merged 4 commits into from
Nov 27, 2023
Merged

[CommonServerPython] Fix Polling Failure If polling Parameter is Missing #31111

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c583e6
Add default value to `args.get()`
MichaelYochpaz Nov 26, 2023
de0098d
Bump version
MichaelYochpaz Nov 26, 2023
b484440
Update release-notes message
MichaelYochpaz Nov 26, 2023
48d4f43
Merge branch 'master' into commonserverpython-fix-polling-bug
MichaelYochpaz Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Packs/Base/ReleaseNotes/1_32_49.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Scripts

##### CommonServerPython

- Fixed an issue where polling commands might not work properly when the `polling` parameter is missing.
MichaelYochpaz marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion Packs/Base/Scripts/CommonServerPython/CommonServerPython.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10383,7 +10383,7 @@ def inner(args, *arguments, **kwargs):
*arguments: any additional arguments to the command function.
**kwargs: additional keyword arguments to the command function.
"""
if not requires_polling_arg or argToBoolean(args.get(polling_arg_name)):
if not requires_polling_arg or argToBoolean(args.get(polling_arg_name, False)):
ScheduledCommand.raise_error_if_not_supported()
poll_result = func(args, *arguments, **kwargs)

Expand Down
2 changes: 1 addition & 1 deletion Packs/Base/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Base",
"description": "The base pack for Cortex XSOAR.",
"support": "xsoar",
"currentVersion": "1.32.48",
"currentVersion": "1.32.49",
"author": "Cortex XSOAR",
"serverMinVersion": "6.0.0",
"url": "https://www.paloaltonetworks.com/cortex",
Expand Down
Loading