Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsEC2SyncAccounts script #31680

Merged
merged 25 commits into from
Jan 9, 2024
Merged

AwsEC2SyncAccounts script #31680

merged 25 commits into from
Jan 9, 2024

Conversation

jlevypaloalto
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Create a script that will configure an instance of AWS EC2 with the AWS accounts retrieved by the command aws-org-account-list.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Dec 23, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AWS-EC2/Scripts/AwsEC2SyncAccounts
   AwsEC2SyncAccounts.py511570%40, 42, 46–47, 95, 98–99, 102, 108–114
TOTAL511570% 

Tests Skipped Failures Errors Time
5 0 💤 0 ❌ 0 🔥 1.902s ⏱️

Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! add good tests with anything that comes externally (api responses, param settings etc, ads json files in test_data

Packs/AWS-EC2/ReleaseNotes/1_3_0.md Outdated Show resolved Hide resolved
Packs/AWS-EC2/Scripts/AwsEC2GetAccounts/README.md Outdated Show resolved Hide resolved
@jlevypaloalto jlevypaloalto changed the title AwsEC2GetAccounts script AwsEC2SyncAccounts script Dec 29, 2023
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good please move to docs review

@ShirleyDenkberg ShirleyDenkberg self-assigned this Jan 8, 2024
@ShirleyDenkberg
Copy link
Contributor

@JudahSchwartz Doc review completed.

Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiice

@jlevypaloalto jlevypaloalto merged commit 8cc4e0b into master Jan 9, 2024
14 checks passed
@jlevypaloalto jlevypaloalto deleted the jl-aws-ec2-get-accounts branch January 9, 2024 13:38
dantavori pushed a commit that referenced this pull request Jan 14, 2024
* init

* finished unit-tests

* docs complete

* update release notes

* docs

* name change

* CR changes

* Bump pack from version AWS-EC2 to 1.3.0.

* Demo changes

* bug fixes

* small changes

* refactor

* fix unit-tests

* added use-case

* Update docker

* build wars: round 1

* Update Packs/AWS-EC2/ReleaseNotes/1_3_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Bump pack from version AWS-EC2 to 1.4.0.

* more tests

* more tests

* ignore secrets

---------

Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants