-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AwsEC2SyncAccounts script #31680
AwsEC2SyncAccounts script #31680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! add good tests with anything that comes externally (api responses, param settings etc, ads json files in test_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good please move to docs review
@JudahSchwartz Doc review completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niiiice
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
* init * finished unit-tests * docs complete * update release notes * docs * name change * CR changes * Bump pack from version AWS-EC2 to 1.3.0. * Demo changes * bug fixes * small changes * refactor * fix unit-tests * added use-case * Update docker * build wars: round 1 * Update Packs/AWS-EC2/ReleaseNotes/1_3_0.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Bump pack from version AWS-EC2 to 1.4.0. * more tests * more tests * ignore secrets --------- Co-authored-by: Content Bot <bot@demisto.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Status
Related Issues
fixes: link to the issue
Description
Create a script that will configure an instance of AWS EC2 with the AWS accounts retrieved by the command
aws-org-account-list
.Must have