Hide sensitive info from logs #33224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 60a9393.
…nfo-from-logs/CIAC-6966
JasBeilin
reviewed
Mar 12, 2024
…nfo-from-logs/CIAC-6966
JasBeilin
reviewed
Mar 12, 2024
Packs/Base/Scripts/CommonServerPython/CommonServerPython_test.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
…ide-sensitive-info-from-logs/CIAC-6966' of https://github.com/demisto/content into YR/Hide-sensitive-info-from-logs/CIAC-6966
…nfo-from-logs/CIAC-6966
dantavori
reviewed
Apr 10, 2024
|
|
||
| SECRET_REPLACEMENT_STRING = '<XX_REPLACED>' | ||
| MASK = '<XX_REPLACED>' | ||
| SEND_PREFIX = "send: b'" |
There was a problem hiding this comment.
Suggested change
| SEND_PREFIX = "send: b'" | |
| SEND_PREFIX = 'send: b"' |
pal-xmco
pushed a commit
to pal-xmco/content
that referenced
this pull request
Jun 19, 2024
* Revert "Sanitize Curl Logs (demisto#31702)" This reverts commit 60a9393. * init * more * try * try * fixes * add tests * more * RN * RN * fix * pre commit * fix tests * fix * fixes * fixes * add test * pre commit * python 2 * Python 2 demisto#2 * Update Packs/Base/Scripts/CommonServerPython/CommonServerPython_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * add description * pre commit --------- Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-6966
Description
We've now ensured that sensitive information directly printed by the request library, especially when debug-mode=true, is properly masked in this PR.
Must have