Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ZipFile image #33825

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Revert ZipFile image #33825

merged 5 commits into from
Apr 8, 2024

Conversation

AradCarmi
Copy link
Contributor

@AradCarmi AradCarmi commented Apr 8, 2024 •
edited
Loading

Related Issues

fixes: link to the issue

Description

Downgrade the docker image due to TPB errors.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CommonScripts/Scripts/ZipFile
   ZipFile.py745920%23–31, 33–34, 36–37, 39–40, 42–45, 47–48, 51–52, 54–55, 58–63, 65–66, 68, 71–72, 74–75, 78–79, 82–85, 87–89, 92, 94–95, 97–98, 101, 105–107, 109–111
TOTAL745920% 

Tests Skipped Failures Errors Time
4 0 💤 0 ❌ 0 🔥 1.621s ⏱️

@AradCarmi
Copy link
Contributor Author

A force merge was needed due to the downgrade of the docker image (DO106 failing validation).
FYI @ShahafBenYakir

@AradCarmi AradCarmi added ForceMerge Forcing the merge of the PR despite the build status docs-approved labels Apr 8, 2024
@ShahafBenYakir ShahafBenYakir merged commit 1483eea into master Apr 8, 2024
13 checks passed
@ShahafBenYakir ShahafBenYakir deleted the Revert_ZipFile_Image branch April 8, 2024 18:05
tcarmeli1 added a commit that referenced this pull request Apr 9, 2024
@samuelFain @AradCarmi
@ilaner @tcarmeli1
demisto/paho-mqtt:1.0.0.56447 | 0-100 | PR batch #1/1 (#33828)
8197c88 
* Updated docker image to demisto/paho-mqtt:1.0.0.56447. PR batch #1/1

* Revert ZipFile image (#33825)

* revert docker image and added the TPB to the yml

* updated release notes

* pre-commit fixes

* updated release notes

* Docker Hardening test - fix flaky test (#33805)

* Revert "Merge branch 'auto_update_docker_staging_branch' into AUD-demisto/paho-mqtt-1.0.0.56447-pr-batch-1"

This reverts commit c5dffd6, reversing
changes made to d9ce372.

* add space

* delete space

* version 29

---------

Co-authored-by: Arad Carmi <62752352+AradCarmi@users.noreply.github.com>
Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com>
Co-authored-by: Tal <tcarmeli@paloaltonetworks.com>
Co-authored-by: Tal Carmeli <158452762+tcarmeli1@users.noreply.github.com>
samuelFain added a commit that referenced this pull request Jun 2, 2024
@samuelFain @talzich
@AradCarmi @ilaner @tcarmeli1
[Auto Update Docker] auto_update_docker_staging_branch (#34465)
de9669c 
* Updated docker image to demisto/pcap-miner:1.0.0.91369. PR batch #1/3 (#33830)

* Updated docker image to demisto/pcap-miner:1.0.0.91369. PR batch #2/3 (#33831)

Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com>

* demisto/paho-mqtt:1.0.0.56447 | 0-100 | PR batch #1/1 (#33828)

* Updated docker image to demisto/paho-mqtt:1.0.0.56447. PR batch #1/1

* Revert ZipFile image (#33825)

* revert docker image and added the TPB to the yml

* updated release notes

* pre-commit fixes

* updated release notes

* Docker Hardening test - fix flaky test (#33805)

* Revert "Merge branch 'auto_update_docker_staging_branch' into AUD-demisto/paho-mqtt-1.0.0.56447-pr-batch-1"

This reverts commit c5dffd6, reversing
changes made to d9ce372.

* add space

* delete space

* version 29

---------

Co-authored-by: Arad Carmi <62752352+AradCarmi@users.noreply.github.com>
Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com>
Co-authored-by: Tal <tcarmeli@paloaltonetworks.com>
Co-authored-by: Tal Carmeli <158452762+tcarmeli1@users.noreply.github.com>

* Fix conflict

* Updated docker image to demisto/py3-tools:1.0.0.91908. PR batch #1/3 (#33871)

* Update release notes

* Validate

* pre-commit

* Fix RN for Anomali ThreatStream v3

* Fix PcapAnalysis.yml file

* update devdemisto/polyswarm

* dockerImage uploaded to docker hub

* revert pcap-minor related changes

* Resolve Packs/CommonScripts merge conflict

* Resolve Packs/CommonScripts merge conflict

* Remove pcap-minor RN file

* Update release notes

* Update release notes

* Update UBIRCH to use demisto/py3-tools instead of demisto/paho-mqtt

* Resolve Packs/CommonScripts merge conflict

* Resolve Packs/Anomali_ThreatStream merge conflict

---------

Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com>
Co-authored-by: Arad Carmi <62752352+AradCarmi@users.noreply.github.com>
Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com>
Co-authored-by: Tal <tcarmeli@paloaltonetworks.com>
Co-authored-by: Tal Carmeli <158452762+tcarmeli1@users.noreply.github.com>
Co-authored-by: TalZich <tzichlinsky@paloaltonetworks.com>
aaron1535 pushed a commit that referenced this pull request Jun 9, 2024
@samuelFain @talzich
@AradCarmi @ilaner @tcarmeli1 @aaron1535
[Auto Update Docker] auto_update_docker_staging_branch (#34465)
34dc75e 
* Updated docker image to demisto/pcap-miner:1.0.0.91369. PR batch #1/3 (#33830)

* Updated docker image to demisto/pcap-miner:1.0.0.91369. PR batch #2/3 (#33831)

Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com>

* demisto/paho-mqtt:1.0.0.56447 | 0-100 | PR batch #1/1 (#33828)

* Updated docker image to demisto/paho-mqtt:1.0.0.56447. PR batch #1/1

* Revert ZipFile image (#33825)

* revert docker image and added the TPB to the yml

* updated release notes

* pre-commit fixes

* updated release notes

* Docker Hardening test - fix flaky test (#33805)

* Revert "Merge branch 'auto_update_docker_staging_branch' into AUD-demisto/paho-mqtt-1.0.0.56447-pr-batch-1"

This reverts commit c5dffd6, reversing
changes made to d9ce372.

* add space

* delete space

* version 29

---------

Co-authored-by: Arad Carmi <62752352+AradCarmi@users.noreply.github.com>
Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com>
Co-authored-by: Tal <tcarmeli@paloaltonetworks.com>
Co-authored-by: Tal Carmeli <158452762+tcarmeli1@users.noreply.github.com>

* Fix conflict

* Updated docker image to demisto/py3-tools:1.0.0.91908. PR batch #1/3 (#33871)

* Update release notes

* Validate

* pre-commit

* Fix RN for Anomali ThreatStream v3

* Fix PcapAnalysis.yml file

* update devdemisto/polyswarm

* dockerImage uploaded to docker hub

* revert pcap-minor related changes

* Resolve Packs/CommonScripts merge conflict

* Resolve Packs/CommonScripts merge conflict

* Remove pcap-minor RN file

* Update release notes

* Update release notes

* Update UBIRCH to use demisto/py3-tools instead of demisto/paho-mqtt

* Resolve Packs/CommonScripts merge conflict

* Resolve Packs/Anomali_ThreatStream merge conflict

---------

Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com>
Co-authored-by: Arad Carmi <62752352+AradCarmi@users.noreply.github.com>
Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com>
Co-authored-by: Tal <tcarmeli@paloaltonetworks.com>
Co-authored-by: Tal Carmeli <158452762+tcarmeli1@users.noreply.github.com>
Co-authored-by: TalZich <tzichlinsky@paloaltonetworks.com>
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
@AradCarmi @pal-xmco
Revert ZipFile image (demisto#33825)
9f694ea 
* revert docker image and added the TPB to the yml

* updated release notes

* pre-commit fixes

* updated release notes
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
@samuelFain @talzich
@AradCarmi @ilaner @tcarmeli1 @pal-xmco
[Auto Update Docker] auto_update_docker_staging_branch (demisto#34465)
bb35b07 
* Updated docker image to demisto/pcap-miner:1.0.0.91369. PR batch demisto#1/3 (demisto#33830)

* Updated docker image to demisto/pcap-miner:1.0.0.91369. PR batch demisto#2/3 (demisto#33831)

Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com>

* demisto/paho-mqtt:1.0.0.56447 | 0-100 | PR batch demisto#1/1 (demisto#33828)

* Updated docker image to demisto/paho-mqtt:1.0.0.56447. PR batch demisto#1/1

* Revert ZipFile image (demisto#33825)

* revert docker image and added the TPB to the yml

* updated release notes

* pre-commit fixes

* updated release notes

* Docker Hardening test - fix flaky test (demisto#33805)

* Revert "Merge branch 'auto_update_docker_staging_branch' into AUD-demisto/paho-mqtt-1.0.0.56447-pr-batch-1"

This reverts commit c5dffd6, reversing
changes made to d9ce372.

* add space

* delete space

* version 29

---------

Co-authored-by: Arad Carmi <62752352+AradCarmi@users.noreply.github.com>
Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com>
Co-authored-by: Tal <tcarmeli@paloaltonetworks.com>
Co-authored-by: Tal Carmeli <158452762+tcarmeli1@users.noreply.github.com>

* Fix conflict

* Updated docker image to demisto/py3-tools:1.0.0.91908. PR batch demisto#1/3 (demisto#33871)

* Update release notes

* Validate

* pre-commit

* Fix RN for Anomali ThreatStream v3

* Fix PcapAnalysis.yml file

* update devdemisto/polyswarm

* dockerImage uploaded to docker hub

* revert pcap-minor related changes

* Resolve Packs/CommonScripts merge conflict

* Resolve Packs/CommonScripts merge conflict

* Remove pcap-minor RN file

* Update release notes

* Update release notes

* Update UBIRCH to use demisto/py3-tools instead of demisto/paho-mqtt

* Resolve Packs/CommonScripts merge conflict

* Resolve Packs/Anomali_ThreatStream merge conflict

---------

Co-authored-by: Tal Zichlinsky <35036457+talzich@users.noreply.github.com>
Co-authored-by: Arad Carmi <62752352+AradCarmi@users.noreply.github.com>
Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com>
Co-authored-by: Tal <tcarmeli@paloaltonetworks.com>
Co-authored-by: Tal Carmeli <158452762+tcarmeli1@users.noreply.github.com>
Co-authored-by: TalZich <tzichlinsky@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JudahSchwartz JudahSchwartz JudahSchwartz approved these changes

@dorschw dorschw Awaiting requested review from dorschw

Assignees
No one assigned
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AradCarmi @JudahSchwartz @ShahafBenYakir