-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyberwatch integration #35224
Cyberwatch integration #35224
Conversation
b4f81ae
to
4b0f2d9
Compare
Hi @tarraschk , |
@tarraschk, |
@samuelFain thank you for your message, I just rebased the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tarraschk, Everything looks great!
Kindly review my comments.
We should schedule a demo along with @edik24 to make sure all the integration commands are functioning as expected, after which we should be good to merge the PR.
You can reach my on slack or mail via this address: sfainberg@paloaltonetworks.com
Thanks!
Packs/Cyberwatch/pack_metadata.json
Outdated
"marketplaces": [ | ||
"xsoar", | ||
"marketplacev2", | ||
"xsoar_on_prem", | ||
"xsoar_saas" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these tags are irrelevant.
If you wish for this integration to run on all XSOAR versions (including XSIAM and XSOAR 8), then these two tags cover all the cases:
"marketplaces": [ | |
"xsoar", | |
"marketplacev2", | |
"xsoar_on_prem", | |
"xsoar_saas" | |
"marketplaces": [ | |
"xsoar", | |
"marketplacev2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done
# elif command == 'fetch-incidents': | ||
# first_fetch = params.get('fetch_time').strip() | ||
# fetch_incidents(client, first_fetch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove commented code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done
16ab9bb
into
demisto:contrib/tarraschk_cyberwatch
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
Co-authored-by: Maxime Alay-Eddine <maxime.alayeddine@gmail.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Asked by common Cyberwatch and Palo Alto customers, no issue open but Cyberwatch has been in touch with Palo Alto Technology Partnerships team.
Cyberwatch is a French cybersecurity software vendor, specialized in Vulnerability and Compliance Management.
Description
This Pull Request provides a Pack with an Integration for the Cyberwatch software.
This PR allows Cortex XSOAR to:
Must have