Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyberwatch integration #35224

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

tarraschk
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Asked by common Cyberwatch and Palo Alto customers, no issue open but Cyberwatch has been in touch with Palo Alto Technology Partnerships team.

Cyberwatch is a French cybersecurity software vendor, specialized in Vulnerability and Compliance Management.

Description

This Pull Request provides a Pack with an Integration for the Cyberwatch software.

This PR allows Cortex XSOAR to:

  • fetch assets from Cyberwatch
  • fetch CVE data from Cyberwatch
  • fetch Security Issues data from Cyberwatch

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

@edik24 edik24 requested a review from samuelFain July 4, 2024 05:49
@edik24 edik24 self-assigned this Jul 4, 2024
@tarraschk tarraschk force-pushed the cyberwatch branch 2 times, most recently from b4f81ae to 4b0f2d9 Compare July 4, 2024 09:39
@samuelFain
Copy link
Contributor

samuelFain commented Jul 7, 2024

Hi @tarraschk ,
Thank you for your contribution!
Your PR review is slightly delayed, and we will complete the review as soon as possible. We apologize for any inconvenience.
In the meantime, please make sure the registration form is filled.
I'm available for any of your questions here or on Slack.
Thanks again.

@samuelFain
Copy link
Contributor

@tarraschk,
Thank you for your contribution and great work :)
Please merge the latest changes from contrib/tarraschk_cyberwatch into this branch (Update branch button) so we can activate the Github workflows needed to verify the changes in this PR.
Please feel free to reach out to me with any questions - I'm available here or on slack.

@tarraschk
Copy link
Contributor Author

@samuelFain thank you for your message, I just rebased the PR

Copy link
Contributor

@samuelFain samuelFain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tarraschk, Everything looks great!
Kindly review my comments.
We should schedule a demo along with @edik24 to make sure all the integration commands are functioning as expected, after which we should be good to merge the PR.
You can reach my on slack or mail via this address: sfainberg@paloaltonetworks.com
Thanks!

Comment on lines 31 to 35
"marketplaces": [
"xsoar",
"marketplacev2",
"xsoar_on_prem",
"xsoar_saas"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these tags are irrelevant.
If you wish for this integration to run on all XSOAR versions (including XSIAM and XSOAR 8), then these two tags cover all the cases:

Suggested change
"marketplaces": [
"xsoar",
"marketplacev2",
"xsoar_on_prem",
"xsoar_saas"
"marketplaces": [
"xsoar",
"marketplacev2",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

Comment on lines 913 to 915
# elif command == 'fetch-incidents':
# first_fetch = params.get('fetch_time').strip()
# fetch_incidents(client, first_fetch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

@samuelFain samuelFain merged commit 16ab9bb into demisto:contrib/tarraschk_cyberwatch Jul 23, 2024
14 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

samuelFain pushed a commit that referenced this pull request Jul 25, 2024
Co-authored-by: Maxime Alay-Eddine <maxime.alayeddine@gmail.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
Co-authored-by: Maxime Alay-Eddine <maxime.alayeddine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved post-demo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants