Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send-notification command to ServiceNow integration #37341

Conversation

nikstuckenbrock
Copy link
Contributor

@nikstuckenbrock nikstuckenbrock commented Nov 21, 2024

Status

  • In Progress
  • Ready

Description

Add send-notification command to ServiceNow integration to directly interact with ServiceNow in ask or data collection tasks.

Must have

  • Tests
  • Documentation

Just as a sidenote: I will be on vacation for the next week, therefor it will take a week for me to respond.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Nov 21, 2024
@content-bot content-bot changed the base branch from master to contrib/nikstuckenbrock_feature/ask-by-servicenow November 21, 2024 11:02
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @amshamah419 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @nikstuckenbrock, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@amshamah419
Copy link
Contributor

Hi @nikstuckenbrock ,

Thank you again for opening a pull request. Unfortunately, we cannot accept it, as this is a significant change which requires an in-house design due to it using a builtin command which is not supported on all platforms quite yet.

Contributions are welcome, and we're looking forward to seeing you commit here again. Please let me know if you have any further questions.

@nikstuckenbrock
Copy link
Contributor Author

Hi @amshamah419,

thanks for your response. I know that it is not supported by all platforms, that's why i created the PR. We can still fork the integration locally, but that's probably bad practice. Could you explain a little bit more why this change i such of a significant change? Because it is downwards capable and only adds a new command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants