Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added URL output field to FeedLOLBAS integration #37363

Conversation

Stjubit
Copy link
Contributor

@Stjubit Stjubit commented Nov 22, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

This pull request extends the FeedLOLBAS integration. A new output field (URL) has been added to the !lolbas-get-indicators command.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Nov 22, 2024
@Stjubit Stjubit marked this pull request as ready for review November 22, 2024 14:44
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Nov 22, 2024
@content-bot content-bot changed the base branch from master to contrib/Stjubit_lolbas-add-fields November 22, 2024 14:45
@content-bot content-bot requested a review from MLainer1 November 22, 2024 14:45
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MLainer1 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @Stjubit, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

Copy link
Contributor

@MLainer1 MLainer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
Make sure to look at the pre-commit error and change the PR accordingly.
Please send a demo video of your contribution to make sure it works as expected.

@MLainer1 MLainer1 added pending-demo Demo pending pending-contributor The PR is pending the response of its creator labels Nov 24, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

3 similar comments
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MLainer1
Copy link
Contributor

Hi @Stjubit, do you need any help with the PR?

@MLainer1
Copy link
Contributor

Hi @Stjubit, I'm closing the PR due to inactivity, feel free to open it again when you have the time to update it.

@MLainer1 MLainer1 closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR pending-contributor The PR is pending the response of its creator pending-demo Demo pending TIM Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants