Changed isSilent to lower case (#4728)

* changed all isSilent to lower case

* added changelog

.changelog/4728.yml

@@ -0,0 +1,4 @@
+changes:
+- description: Changed the isSilent key to be lower case.
+  type: fix
+pr_number: 4728

demisto_sdk/commands/common/hook_validations/content_entity_validator.py

@@ -699,7 +699,7 @@ def validate_readme_exists(self, validate_all: bool = False):
         path_split = file_path.split(os.sep)
         file_type = find_type(self.file_path, _dict=self.current_file, file_type="yml")
         if file_type == FileType.PLAYBOOK:
-            if self.current_file.get("isSilent"):
+            if self.current_file.get("issilent"):
                 return True
             to_replace = os.path.splitext(path_split[-1])[-1]
             readme_path = file_path.replace(to_replace, "_README.md")

demisto_sdk/commands/common/hook_validations/release_notes.py

@@ -222,7 +222,7 @@ def are_release_notes_complete(self):
                 ):
                     try:
                         _dict, file_type = get_dict_from_file(file)
-                        if _dict.get("isSilent"):
+                        if _dict.get("issilent"):
                             continue
                     except Exception:
                         pass

demisto_sdk/commands/common/schemas/playbook.yml

@@ -38,7 +38,7 @@ mapping:
     type: bool
   deprecated:
     type: bool
-  isSilent:
+  issilent:
     type: bool
   starttaskid:
     type: str

demisto_sdk/commands/common/schemas/trigger.yml

@@ -16,7 +16,7 @@ mapping:
   description:
     type: str
     required: true
-  isSilent:
+  issilent:
     type: bool
   suggestion_reason:
     type: str

demisto_sdk/commands/content_graph/parsers/json_content_item.py

@@ -114,4 +114,4 @@ def version(self) -> int:
 
     @property
     def is_silent(self) -> bool:
-        return get_value(self.json_data, "isSilent", False)
+        return get_value(self.json_data, "issilent", False)

demisto_sdk/commands/content_graph/parsers/yaml_content_item.py

@@ -78,7 +78,7 @@ def deprecated(self) -> bool:
 
     @property
     def is_silent(self) -> bool:
-        return get_value(self.yml_data, "isSilent", False)
+        return get_value(self.yml_data, "issilent", False)
 
     @property
     def description(self) -> Optional[str]:

demisto_sdk/commands/content_graph/strict_objects/playbook.py

@@ -291,4 +291,4 @@ class StrictPlaybook(BaseStrictModel):
     tests: Optional[List[str]] = None
     role_name: Optional[List[str]] = Field(None, alias="rolename")
     marketplaces: Optional[List[MarketplaceVersions]] = None
-    is_silent: Optional[bool] = Field(alias="isSilent")
+    is_silent: Optional[bool] = Field(alias="issilent")

demisto_sdk/commands/validate/tests/PB_validators_test.py

@@ -1409,14 +1409,14 @@ def test_MarketplaceKeysHaveDefaultValidator(
 def test_IsSilentPlaybookValidator(name, id, is_silent, result_len):
     """
     Given:
-        case 1: isSilent = False, and name/id do not contain silent prefix.
-        case 2: isSilent = True, and name/id contain silent prefix.
-        case 3: isSilent = True, name contain and id do not contain silent prefix.
-        case 4: isSilent = True, id contain and name do not contain silent prefix.
-        case 5: isSilent = False, and name/id contain silent prefix.
-        case 6: isSilent = False, name contain and id do not contain silent prefix.
-        case 7: isSilent = False, id contain and name do not contain silent prefix.
-        case 8: isSilent = True, and name/id do not contain silent prefix.
+        case 1: issilent = False, and name/id do not contain silent prefix.
+        case 2: issilent = True, and name/id contain silent prefix.
+        case 3: issilent = True, name contain and id do not contain silent prefix.
+        case 4: issilent = True, id contain and name do not contain silent prefix.
+        case 5: issilent = False, and name/id contain silent prefix.
+        case 6: issilent = False, name contain and id do not contain silent prefix.
+        case 7: issilent = False, id contain and name do not contain silent prefix.
+        case 8: issilent = True, and name/id do not contain silent prefix.
 
     When:
     - calling IsSilentPlaybookValidator.obtain_invalid_content_items.
@@ -1427,7 +1427,7 @@ def test_IsSilentPlaybookValidator(name, id, is_silent, result_len):
     playbook = create_playbook_object()
     playbook.data["id"] = id
     playbook.data["name"] = name
-    playbook.data["isSilent"] = is_silent
+    playbook.data["issilent"] = is_silent
 
     invalid_content_items = IsSilentPlaybookValidator().obtain_invalid_content_items(
         [playbook]

demisto_sdk/commands/validate/validators/PB_validators/PB130_is_silent_playbook.py

@@ -13,9 +13,9 @@
 
 class IsSilentPlaybookValidator(BaseValidator[ContentTypes]):
     error_code = "PB130"
-    description = "Validate that the name and ID of a silent-Playbook contain the silent prefix and include the field isSilent: true"
-    rationale = "In silent-Playbook the name and ID prefix should be silent and also include the field isSilent: true"
-    error_message = "Silent-Playbook should have silent as a prefix in the name and ID, as well as the field isSilent: true, one of them is missing."
+    description = "Validate that the name and ID of a silent-Playbook contain the silent prefix and include the field issilent: true"
+    rationale = "In silent-Playbook the name and ID prefix should be silent and also include the field issilent: true"
+    error_message = "Silent-Playbook should have silent as a prefix in the name and ID, as well as the field issilent: true, one of them is missing."
     related_field = ""
     is_auto_fixable = False
 
@@ -30,14 +30,14 @@ def obtain_invalid_content_items(
             )
             for content_item in content_items
             if (
-                content_item.data.get("isSilent")
+                content_item.data.get("issilent")
                 or any(
                     content_item.data.get(key, "").startswith("silent")
                     for key in ["name", "id"]
                 )
             )
             and not (
-                content_item.data.get("isSilent")
+                content_item.data.get("issilent")
                 and all(
                     content_item.data.get(key, "").startswith("silent")
                     for key in ["name", "id"]

demisto_sdk/commands/validate/validators/PB_validators/PB131_is_silent_playbook_relationships.py

@@ -21,7 +21,7 @@ class IsSilentPlaybookRelationshipsValidator(BaseValidator[ContentTypes]):
     error_message = (
         "The {} is silent, but does not correspond to a silent {} in the pack."
     )
-    related_field = "isSilent"
+    related_field = "issilent"
     is_auto_fixable = False
 
     def obtain_invalid_content_items(

demisto_sdk/commands/validate/validators/PB_validators/PB132_no_readme_for_silent_playbook.py

@@ -16,7 +16,7 @@ class NoReadmeForSilentPlaybook(BaseValidator[ContentTypes]):
     description = "A silent playbook is not allowed to have a README file."
     rationale = "To ensure that silent playbooks do not appears in the documentation."
     error_message = "A silent playbook is not allowed to have a README file."
-    related_field = "isSilent"
+    related_field = "issilent"
     is_auto_fixable = False
 
     def obtain_invalid_content_items(

demisto_sdk/scripts/tests/validate_deleted_files_test.py

@@ -122,7 +122,7 @@ def test_get_forbidden_deleted_files_deleting_silent_playbook(git_repo: Repo):
     pack = git_repo.create_pack("Test")
     silent_playbook = pack.create_playbook("name")
 
-    silent_playbook.yml.update({"isSilent": "true"})
+    silent_playbook.yml.update({"issilent": "true"})
 
     git_repo.git_util.commit_files("create pack and silent playbook")
     git_repo.git_util.repo.git.checkout("-b", "delete_playbook")

demisto_sdk/scripts/validate_deleted_files.py

@@ -57,7 +57,7 @@ def is_file_allowed_to_be_deleted_by_file_type(file_path: Path) -> bool:
 
 def check_if_content_item_is_silent(file_dict):
     if isinstance(file_dict, dict):
-        if file_dict.get("isSilent"):
+        if file_dict.get("issilent"):
             return True
     return False