Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use precommit template from content #3159

Merged
merged 24 commits into from
Jun 19, 2023
Merged

use precommit template from content #3159

merged 24 commits into from
Jun 19, 2023

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Jun 18, 2023 •
edited by dorschw
Loading

move the pre-commit template to content (see #3159)

ilaner and others added 2 commits June 18, 2023 14:30
@ilaner @dorschw
Update demisto_sdk/commands/common/tools.py
eef84c1 
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
syntax error
c8896b3
@dorschw dorschw mentioned this pull request Jun 18, 2023
Merged
@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 17ceeaa2-25fc-48cb-a315-c5b816170930

  • 27 of 37 (72.97%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 81.437%
Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/pre_commit/pre_commit_command.py 11 12 91.67%
demisto_sdk/commands/common/tools.py 15 24 62.5%
Totals Coverage Status
Change from base Build 1de62f36-4132-4142-9487-4419af7c0a5b: 0.04%
Covered Lines: 30868
Relevant Lines: 37904
💛 - Coveralls

@ilaner ilaner requested a review from dantavori as a code owner June 18, 2023 15:23
ilan added 2 commits June 19, 2023 16:42
@ilaner ilaner requested a review from dorschw June 19, 2023 14:25
ilan added 2 commits June 19, 2023 17:31
@ilaner ilaner merged commit af4ad9d into master Jun 19, 2023
@ilaner ilaner deleted the pre_commit_template_in_content branch June 19, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw approved these changes

@dantavori dantavori Awaiting requested review from dantavori dantavori is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilaner @coveralls @dorschw