Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pretty name to incident field schema #3171

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Added pretty name to incident field schema #3171

merged 4 commits into from
Jun 20, 2023

Conversation

dansterenson
Copy link
Contributor

@dansterenson dansterenson commented Jun 20, 2023 •
edited
Loading

@dansterenson dansterenson requested a review from ilaner June 20, 2023 10:07
ilaner
ilaner suggested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@ilaner ilaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test for StructureValidator where you provide an incident field and incident fields with prettyName and make sure that structure validator passes

@dansterenson dansterenson requested a review from ilaner June 20, 2023 12:22
@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 8b69d4e2-af7d-4528-8e98-d725389f81a2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 81.422%
Totals Coverage Status
Change from base Build 9174e43e-728a-40fd-ae65-96c5d756f754: 0.07%
Covered Lines: 30884
Relevant Lines: 37931
💛 - Coveralls

@dansterenson dansterenson merged commit 1460ad5 into master Jun 20, 2023
@dansterenson dansterenson deleted the add-pretty-name-to-incidentfield-schema branch June 20, 2023 13:00
@dansterenson dansterenson mentioned this pull request Jun 20, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilaner ilaner ilaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dansterenson @coveralls @ilaner