Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format bug #4313

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Format bug #4313

merged 9 commits into from
Jun 4, 2024

Conversation

merit-maita
Copy link
Contributor

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-37005

Description

  • Fixed an issue where Format command did not work with Private github repos

Copy link

Changelog(s) in markdown:

  • Fixed an issue where format did not work with private github repositories. #4313

"""
Checks the class variable, prints if necessary, and sets the class variable to avoid multiple prints
"""
if not GitContentConfig.NOTIFIED_PRIVATE_REPO:
provider = "github" if self.git_provider == GitProvider.GitHub else "gitlab"
token = (
Copy link
Contributor

@thefrieddan1 thefrieddan1 May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refactor token to token_name

@merit-maita merit-maita merged commit 36e623a into master Jun 4, 2024
25 checks passed
@merit-maita merit-maita deleted the format_bug branch June 4, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants