Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optional exceptions to search_substrings_by_line #4341

Merged
merged 13 commits into from
Jun 16, 2024
Merged

add optional exceptions to search_substrings_by_line #4341

merged 13 commits into from
Jun 16, 2024

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Jun 13, 2024 •
edited
Loading

@dorschw dorschw changed the title change argument/variable names add optional exceptions to search_substrings_by_line Jun 13, 2024
@dorschw dorschw requested a review from YuvHayun June 13, 2024 16:28
@dorschw dorschw marked this pull request as ready for review June 13, 2024 16:28
samuelFain
samuelFain approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@samuelFain samuelFain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice!

@dorschw dorschw merged commit 97f0d41 into master Jun 16, 2024
25 checks passed
@dorschw dorschw deleted the ds-search-substrings branch June 16, 2024 10:07
@content-bot content-bot mentioned this pull request Jun 18, 2024
Merged
@samuelFain samuelFain mentioned this pull request Jun 19, 2024
Merged
This was referenced Jul 29, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelFain samuelFain samuelFain approved these changes

@YuvHayun YuvHayun Awaiting requested review from YuvHayun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorschw @samuelFain