Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation ds106 #4357

Merged
merged 10 commits into from
Jun 17, 2024
Merged

Validation ds106 #4357

merged 10 commits into from
Jun 17, 2024

Conversation

moishce
Copy link
Contributor

@moishce moishce commented Jun 17, 2024

@moishce moishce marked this pull request as ready for review June 17, 2024 12:26
YuvHayun
YuvHayun approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Minor comments.

demisto_sdk/commands/validate/validators/DS_validators/DS106_is_valid_description_name.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/DS_validators/DS106_is_valid_description_name.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/DS_validators/DS106_is_valid_description_name.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/tests/DS_validators_test.py Outdated Show resolved Hide resolved
@moishce
fixed cr comment
b791ae0
@moishce
pre commit
e641e64
@moishce
Merge branch 'master' of github.com:demisto/demisto-sdk into validati…
35f4eec 
…on-DS106

# Conflicts:
#	demisto_sdk/commands/validate/sdk_validation_config.toml
#	demisto_sdk/commands/validate/tests/DS_validators_test.py
@moishce
revert
73f8b6f
@moishce
revert
61e76da
@moishce
revert
0b0aedf
@moishce moishce merged commit 2fa7ee2 into master Jun 17, 2024
25 checks passed
@moishce moishce deleted the validation-DS106 branch June 17, 2024 18:49
@content-bot content-bot mentioned this pull request Jun 18, 2024
Merged
@samuelFain samuelFain mentioned this pull request Jun 19, 2024
Merged
This was referenced Jul 29, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuvHayun YuvHayun YuvHayun approved these changes

@ShahafBenYakir ShahafBenYakir Awaiting requested review from ShahafBenYakir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moishce @YuvHayun