-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PB108 to the new validate #4359
Conversation
Changelog(s) in markdown:
|
Changelog(s) in markdown:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
See my comments.
demisto_sdk/commands/validate/validators/PB_validators/PB108_is_valid_task_id.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/PB_validators/PB108_is_valid_task_id.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/PB_validators/PB108_is_valid_task_id.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/PB_validators/PB108_is_valid_task_id.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Minor comments.
Approved from my side.
demisto_sdk/commands/validate/validators/PB_validators/PB108_is_valid_task_id.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/PB_validators/PB108_is_valid_task_id.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, please see my comment before merging.
Related Issues
fixes:
Description
Add PB108 to the new validate