Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PB108 to the new validate #4359

Merged
merged 15 commits into from
Jun 18, 2024
Merged

Add PB108 to the new validate #4359

merged 15 commits into from
Jun 18, 2024

Conversation

RotemAmit
Copy link
Contributor

Related Issues

fixes:

Description

Add PB108 to the new validate

@RotemAmit RotemAmit requested a review from YuvHayun June 17, 2024 13:15
Copy link

Changelog(s) in markdown:

  • Moved BP108 to the new validate #4359

Copy link

Changelog(s) in markdown:

  • Moved PB108 to the new validate #4359

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.
See my comments.

@RotemAmit RotemAmit requested a review from YuvHayun June 18, 2024 06:30
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Minor comments.
Approved from my side.

Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, please see my comment before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants