Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting file name validations to run as a pre-commit hook #4476

Merged
merged 15 commits into from
Aug 13, 2024
Merged

Converting file name validations to run as a pre-commit hook #4476

merged 15 commits into from
Aug 13, 2024

Conversation

RosenbergYehuda
Copy link
Contributor

@RosenbergYehuda RosenbergYehuda commented Aug 7, 2024 •
edited
Loading

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-7819
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-11382

Description

Converted the following validations, to run in pre-commit instead of validate.

  • XD100
  • PR100

@RosenbergYehuda RosenbergYehuda changed the title init Converting file name validations to run as in pre-commit hook Aug 8, 2024
@RosenbergYehuda RosenbergYehuda self-assigned this Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Changelog(s) in markdown:

  • Moved PR100 and XD100 validations to run as a pre-commit hook. These validations ensure the ParsingRule and XSIAM Dashboard filenames are valid. #4476

@RosenbergYehuda RosenbergYehuda changed the title Converting file name validations to run as in pre-commit hook Converting file name validations to run as a pre-commit hook Aug 11, 2024
JasBeilin
JasBeilin reviewed Aug 11, 2024
View reviewed changes
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

demisto_sdk/scripts/validate_content_path.py Outdated Show resolved Hide resolved
demisto_sdk/scripts/validate_content_path.py Outdated Show resolved Hide resolved
demisto_sdk/scripts/validate_content_path.py Outdated Show resolved Hide resolved
RosenbergYehuda and others added 3 commits August 11, 2024 17:02
@RosenbergYehuda @JasBeilin
Apply suggestions from code review
8fa5cd6 
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
@RosenbergYehuda
Merge remote-tracking branch 'origin/master' into YR/Convert-XD100-to…
81ec7f9 
…-the-new-format/CIAC-7819
@RosenbergYehuda
txt
76f2a7d
dorschw
dorschw reviewed Aug 12, 2024
View reviewed changes
.changelog/4476.yml Outdated Show resolved Hide resolved
@RosenbergYehuda @dorschw
fixes from ci
452c5a6 
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Moved PR100 and XD100 validations to run the validate-content-path pre-commit hook. These validations ensure the ParsingRule and XSIAM Dashboard filenames are valid. #4476

@RosenbergYehuda RosenbergYehuda merged commit 5cbe877 into master Aug 13, 2024
25 checks passed
@RosenbergYehuda RosenbergYehuda deleted the YR/Convert-XD100-to-the-new-format/CIAC-7819 branch August 13, 2024 10:00
@content-bot content-bot mentioned this pull request Aug 14, 2024
Merged
@content-bot content-bot mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw approved these changes

@JasBeilin JasBeilin JasBeilin approved these changes

@YuvHayun YuvHayun Awaiting requested review from YuvHayun

Assignees

@RosenbergYehuda RosenbergYehuda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RosenbergYehuda @JasBeilin @dorschw