Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Failure During Docker Creation #4648

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Conversation

shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Nov 10, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12137

Description

  • description: Fixed an issue where logging would fail when creating a Docker image.
 File "content/.venv/lib/python3.10/site-packages/demisto_sdk/commands/common/docker_helper.py", line 479, in get_or_create_test_image
    logger.critical(f"{log_prompt} - Build errors occurred: {errors}")
  File "content/.venv/lib/python3.10/site-packages/loguru/_logger.py", line 2060, in critical
    __self._log("CRITICAL", False, __self._options, __message, args, kwargs)
  File "content/.venv/lib/python3.10/site-packages/loguru/_logger.py", line 2017, in _log
    colored_message = Colorizer.prepare_simple_message(str(message))
  File "content/.venv/lib/python3.10/site-packages/loguru/_colorizer.py", line 368, in prepare_simple_message
    parser.feed(string)
  File "content/.venv/lib/python3.10/site-packages/loguru/_colorizer.py", line 252, in feed
    raise ValueError(
ValueError: Tag "<2.0.0,>" does not correspond to any known color directive, make sure you did not misspelled it (or prepend '\' to escape it)

@shmuel44 shmuel44 self-assigned this Nov 10, 2024
Copy link

Changelog(s) in markdown:

  • Fixed an issue where critical-logging in docker failed. #4648

@shmuel44 shmuel44 changed the title Fixed Docker logger Logging Failure During Docker Creation Nov 10, 2024
Copy link

Changelog(s) in markdown:

  • Fixed an issue where logging would fail when creating a Docker image. #4648

@shmuel44 shmuel44 marked this pull request as ready for review November 10, 2024 08:38
@shmuel44 shmuel44 requested a review from dorschw November 10, 2024 08:38
@shmuel44 shmuel44 merged commit 4c59755 into master Nov 10, 2024
26 of 29 checks passed
@shmuel44 shmuel44 deleted the sk_fix_docker_loguru branch November 10, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants