Fix logger setup #4657
Merged
Fix logger setup #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
dorschw
reviewed
Nov 12, 2024
| """ | ||
| global logger | ||
| _setup_neo4j_logger() | ||
|
|
||
| logger.remove(None) # Removes all pre-existing handlers | ||
| logger.remove() # Removes all pre-existing handlers |
There was a problem hiding this comment.
you sure passing None vs nothing still achieves what we wanted?
There was a problem hiding this comment.
Default value is None then yes, and it is less confusing that way imo. https://loguru.readthedocs.io/en/stable/api/logger.html#loguru._logger.Logger.remove
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
|
Changelog(s) in markdown:
|
thefrieddan1
approved these changes
Nov 12, 2024
This was referenced Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: CIAC-12159
Description
When using 'demisto-sdk' as a library within content scripts/integrations, the new logging setup/initialization conflicts with existing logger and causes the container to crash when initialized statically.
Additionally, logs does not show up on default python's logging which is used in content scripts/integration.
Solution: