Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Silent Playbook name/id #4662

Merged
merged 6 commits into from
Dec 15, 2024
Merged

Validate Silent Playbook name/id #4662

merged 6 commits into from
Dec 15, 2024

Conversation

moishce
Copy link
Contributor

@moishce moishce commented Nov 12, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12153

Description

@moishce moishce requested a review from YuvHayun as a code owner November 12, 2024 13:22
Copy link

Changelog(s) in markdown:

  • Added validation checks whether the silent playbook name id and the isSilent key are set correctly. #4662

)
def test_IsSilentPlaybookValidator(name, id, is_silent, result_len):
"""
Given:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l'ets elaborate on the cases

@moishce moishce merged commit 6ad26b1 into master Dec 15, 2024
25 checks passed
@moishce moishce deleted the silent-validate-name branch December 15, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants