Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rm108 by removing conent-assets absulote-link #4683

Closed
wants to merge 7 commits into from
Closed

fix rm108 by removing conent-assets absulote-link #4683

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b739600
fix rm108 by removing conent-assets absulote-link
maimorag Nov 26, 2024
29b76fc
adding change log
maimorag Nov 26, 2024
8eef50b
Merge branch 'master' into fix-rm108-ciac10610
maimorag Nov 26, 2024
1013ab7
pre-commit
maimorag Nov 26, 2024
b3b400f
fix cr
maimorag Nov 28, 2024
d7af4ef
fix validation
maimorag Dec 10, 2024
53da0e8
revert default config
maimorag Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/4683.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changes:
- description: Fixed an issue where content-assets absolute paths raised an error from RM108 validation.
type: internal
pr_number: 4683
3 changes: 3 additions & 0 deletions demisto_sdk/commands/validate/validators/RM_validators/RM108_is_image_path_valid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ def detect_absolute_image_paths(self, content_item) -> str:
# based on whether the link matches the URL or HTML pattern.
absolute_link[1] if absolute_link[0] else absolute_link[2]
for absolute_link in absolute_links
# removing content-assets links
if "content-assets"
not in (absolute_link[1] if absolute_link[0] else absolute_link[2])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fail if this isn't an image (mpv4/gif/etc..) and in content-assets

]

return (
Expand Down