Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding another option for path check #4717

Merged
merged 15 commits into from
Dec 19, 2024
Merged

adding another option for path check #4717

merged 15 commits into from
Dec 19, 2024

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Dec 17, 2024 •
edited
Loading

Related Issues

fixes: None

Description

Images in path Packs/ShiftManagement/doc_files couldn't been access, after adding another option by checking the path with ShiftManagement/doc_files only it managed to find the file- It look like concatenate "/Packs" twice in path_validate.convert

@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where RM114 failed since it concatenate "/Packs" twice. #4717

@maimorag
Copy link
Contributor Author

Tests::

  1. Packs/ShiftManagement/Playbooks/Assign_Active_Incidents_to_Next_Shift_V2.yml which has existing image:
    /Users/mmorag/dev/demisto/content/Packs/ShiftManagement/doc_files/Assign_Active_Incidents_to_Next_Shift_V2.png
    got:
    All validations passed.

  2. Packs/ShiftManagement/Playbooks/Assign_Active_Incidents_to_Next_Shift_V2.yml which has not existing image:
    /Users/mmorag/dev/demisto/content/Packs/ShiftManagement/doc_files/Assign_Active_Incidents_to_Next_Shift_V2_not_exist.png
    got:
    Packs/ShiftManagement/Playbooks/Assign_Active_Incidents_to_Next_Shift_V2.yml: [RM114] - The following images do not exist or have additional characters present in their declaration within the README: Packs/ShiftManagement/doc_files/Assign_Active_Incidents_to_Next_Shift_V2_not exists.png

@maimorag maimorag requested a review from BEAdi December 18, 2024 08:56
@maimorag maimorag marked this pull request as ready for review December 18, 2024 13:49
@maimorag maimorag requested a review from YuvHayun as a code owner December 18, 2024 13:49
BEAdi
BEAdi approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

demisto_sdk/commands/validate/validators/RM_validators/RM114_is_image_exists_in_readme.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/RM_validators/RM114_is_image_exists_in_readme.py Outdated Show resolved Hide resolved
.changelog/4717.yml Outdated Show resolved Hide resolved
maimorag and others added 8 commits December 19, 2024 14:57
@maimorag @BEAdi
Update .changelog/4717.yml
8778d79 
Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
@maimorag @BEAdi
Update demisto_sdk/commands/validate/validators/RM_validators/RM114_i…
c24bea6 
…s_image_exists_in_readme.py

Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
@maimorag
fix
afd1363
@maimorag
fix
0dd3c8f
@maimorag
fix
ae48ff7
@maimorag
fix
d1ebfe6
@maimorag
fix
d5a8ed6
@maimorag
adding unit test
a53fb13
@maimorag maimorag merged commit 049548c into master Dec 19, 2024
22 checks passed
@maimorag maimorag deleted the fix_RM114 branch December 19, 2024 15:59
@RotemAmit RotemAmit mentioned this pull request Dec 25, 2024
Closed
This was referenced Dec 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BEAdi BEAdi BEAdi approved these changes

@YuvHayun YuvHayun Awaiting requested review from YuvHayun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maimorag @BEAdi