Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum Validation for --update-type Flag in update-release-notes Command #4765

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Jan 13, 2025

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12598

Description

Fixed an issue where the update-release-notes delete the version from the pack metadata when using the -u flag with an invalid value
After the fix:

image

@shmuel44 shmuel44 changed the title update-release-notes fix -u flag Enum Validation for --update-type Flag in update-release-notes Command Jan 13, 2025
Copy link

Changelog(s) in markdown:

  • Fixed an issue where the update-release-notes command would delete the version from the pack metadata when using the -u flag with an invalid value. #4765

@shmuel44 shmuel44 self-assigned this Jan 13, 2025
@shmuel44 shmuel44 requested a review from BEAdi January 13, 2025 09:33
@shmuel44 shmuel44 marked this pull request as ready for review January 13, 2025 09:33
Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, please add a UT.

@shmuel44 shmuel44 merged commit 4208caa into master Jan 13, 2025
27 checks passed
@shmuel44 shmuel44 deleted the sk_fix_u_flag_in_update branch January 13, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants