-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add id set validations - script using real cmds, incident type has real default PB #997
Conversation
Pull Request Test Coverage Report for Build afc6eb09-ce92-4241-9e5f-e57adf3cc3cf
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok,
@roysagi make sure to include this validation when migrating to content objects.
Not merging till we will know that the content is valid: demisto/content#10766 |
id set validations on msater are green: https://app.circleci.com/pipelines/github/demisto/content/58518/workflows/7d5d9eae-d4d9-4425-9e7b-487620c399ab/jobs/244449 @yuvalbenshalom FYI. |
Status
Description
Aside from the added validations there was code in the id.py that was not called
is_id_duplicated
,is_file_has_used_id
- so I deleted him.Related Issues
fixes: https://github.com/demisto/etc/issues/29559
Must have