Skip to content

Commit

Permalink
remove lifetime workaround now that this is fixed
Browse files Browse the repository at this point in the history
The underlying issue was fixed in rust 1.69.0.  Our minimum supported rust is now 1.70.0 (set in azure_core), which means this workaround is no longer needed.

Ref: rust-lang/rust#63033
  • Loading branch information
Brian Caswell committed Sep 21, 2023
1 parent 46881d6 commit 2d998d1
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions sdk/identity/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ log = "0.4"
async-trait = "0.1"
openssl = { version = "0.10.46", optional=true }
uuid = { version = "1.0", features = ["v4"] }
# work around https://github.com/rust-lang/rust/issues/63033
fix-hidden-lifetime-bug = "0.2"
pin-project = "1.0"

[dev-dependencies]
Expand Down
2 changes: 0 additions & 2 deletions sdk/identity/src/client_credentials_flow/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ use std::sync::Arc;
use url::{form_urlencoded, Url};

/// Perform the client credentials flow
#[allow(clippy::manual_async_fn)]
#[fix_hidden_lifetime_bug::fix_hidden_lifetime_bug]
pub async fn perform(
http_client: Arc<dyn HttpClient>,
client_id: &str,
Expand Down
2 changes: 0 additions & 2 deletions sdk/identity/src/federated_credentials_flow/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ use std::sync::Arc;
use url::{form_urlencoded, Url};

/// Perform the client credentials flow
#[allow(clippy::manual_async_fn)]
#[fix_hidden_lifetime_bug::fix_hidden_lifetime_bug]
pub async fn perform(
http_client: Arc<dyn HttpClient>,
client_id: &str,
Expand Down
2 changes: 0 additions & 2 deletions sdk/identity/src/refresh_token.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ use std::sync::Arc;
use url::{form_urlencoded, Url};

/// Exchange a refresh token for a new access token and refresh token
#[allow(clippy::manual_async_fn)]
#[fix_hidden_lifetime_bug::fix_hidden_lifetime_bug]
pub async fn exchange(
http_client: Arc<dyn HttpClient>,
tenant_id: &str,
Expand Down

0 comments on commit 2d998d1

Please sign in to comment.