-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonicalize option type annotations #140
Conversation
Oh wow I didn't know about this. Thanks for bringing this up!
I really hate this cheese moving. (not you're fault just venting) |
Ok fixed CI I think : #141 |
Could you give this a rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also would you mind updating TaskOptionCE and JobOptionCE?
I edited this directly on GitHub. Would it be possible for you to just do a rebase while merging? Should be an arrow by the merge button. (If not, you can enable it in the repo settings.) I'll see about TaskOption and JobOption. |
Done and done (rebased, too). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
- [Canonicalize option type annotations](#140) Credits [@cmeeren](https://github.com/cmeeren)
- [Canonicalize option type annotations](#140) Credits [@cmeeren](https://github.com/cmeeren)
- [Canonicalize option type annotations](demystifyfp#140) Credits [@cmeeren](https://github.com/cmeeren)
- [Canonicalize option type annotations](demystifyfp#140) Credits [@cmeeren](https://github.com/cmeeren)
This changes all
Option<_>
type annotations to the idiomatic_ option
form.I have long been annoyed at
Option<_>
Intellisense type hints across my solution when I useasyncOption
. Suddenly realized I could probably do something about it fairly easily by creating a trivial PR. 😅